New issue
Advanced search Search tips

Issue 834731 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
Modern-Media-Controls


Sign in to add a comment

Loading spinner is not vertically aligned with the play button

Project Member Reported by fbeaufort@chromium.org, Apr 19 2018

Issue description

Chrome Version       : 68.0.3397.0
OS Version: 10594.0.0

What steps will reproduce the problem?
1. Enable New Media Controls flag at chrome://flags/#enable-modern-media-controls
2. Go to https://beaufortfrancois.github.io/sandbox/media/preload-or-not.html

What is the expected result?
Loading spinner should be vertically aligned with the play button

What happens instead of that?
It's not. See screen record attached.
 
loading.mov
88.3 KB View Download
Labels: -Pri-3 Pri-2
Owner: steimel@chromium.org
Status: Assigned (was: Unconfirmed)
Components: Blink>Media>Controls
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3850a6a513cdd482d68e22f94f6c4a5968492eb1

commit 3850a6a513cdd482d68e22f94f6c4a5968492eb1
Author: Tommy Steimel <steimel@chromium.org>
Date: Thu Apr 26 18:56:00 2018

Media Controls: Adjust loading CSS to account for larger timeline

For  crbug.com/814958 , we increased the height of the timeline. However,
we did not also adjust the CSS pixel values for the loading panel. This
CL adjusts the values to realign the spinner with the overlay play
button.

Bug:  834731 
Change-Id: I00bd0479f3a6fb1b29505e8a8906d7d92524938f
Reviewed-on: https://chromium-review.googlesource.com/1024806
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554104}
[modify] https://crrev.com/3850a6a513cdd482d68e22f94f6c4a5968492eb1/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls_loading.css

Status: Fixed (was: Started)

Sign in to add a comment