webkitpy.layout_tests.controllers.repaint_overlay_unittest.TestRepaintOverlay.test_generate_repaint_overlay_html fails on local machines |
|||
Issue description
Chrome Version: ToT
OS: macOS and Linux
What steps will reproduce the problem?
(1) run third_party/WebKit/Tools/Scripts/test-webkitpy
What is the expected result?
No failures.
What happens instead?
[1289/1506] webkitpy.layout_tests.controllers.repaint_overlay_unittest.TestRepaintOverlay.test_generate_repaint_overlay_html failed unexpectedly:
Traceback (most recent call last):
File "/Users/tkent/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/repaint_overlay_unittest.py", line 82, in test_generate_repaint_overlay_html
(overlay_html_file, actual_overlay_html_file, actual_overlay_html_file, overlay_html_file))
AssertionError: This failure is probably caused by changed repaint_overlay.py. Please examine the diffs:
diff /Users/tkent/chrome/src/third_party/WebKit/LayoutTests/paint/invalidation/repaint-overlay/layers-overlay.html /Users/tkent/chrome/src/out/Release/layout-test-results/layers-overlay.html
If the diffs are valid, update the file:
cp /Users/tkent/chrome/src/out/Release/layout-test-results/layers-overlay.html /Users/tkent/chrome/src/third_party/WebKit/LayoutTests/paint/invalidation/repaint-overlay/layers-overlay.html
then update layers-overlay-expected.html in the same directory if needed, and commit the files together with the changed repaint_overlay.py.
Please use labels and text to provide additional information.
% diff /Users/tkent/chrome/src/third_party/WebKit/LayoutTests/paint/invalidation/repaint-overlay/layers-overlay.html /Users/tkent/chrome/src/out/Release/layout-test-results/layers-overlay.html
59a60,70
> "bounds": [800, 600],
> "drawsContent": false,
> "backgroundColor": "#FFFFFF"
> },
> {
> "name": "Scrolling Layer",
> "bounds": [800, 600],
> "drawsContent": false
> },
> {
> "name": "Scrolling Contents Layer",
141c152,153
< ]
---
> ],
> "flattenInheritedTransform": false
191a204,214
> "bounds": [800, 600],
> "drawsContent": false,
> "backgroundColor": "#FFFFFF"
> },
> {
> "name": "Scrolling Layer",
> "bounds": [800, 600],
> "drawsContent": false
> },
> {
> "name": "Scrolling Contents Layer",
273c296,297
< ]
---
> ],
> "flattenInheritedTransform": false
,
Apr 19 2018
I can reproduce this locally on ToT and a revision on Apr 10. I'm wondering why the bots didn't fail. qyearsley@ which bots are running test-webkitpy?
,
Apr 19 2018
I saw this before too when running locally -- thank you tkent@ for filing the bug and wangxianzhu@ for investigating! It appears that currently, apart from on the chromium.webkit waterfall, the blink python tests (step name webkit_python_tests) which includes test-webkitpy, may be run on "* Tests" bots on the linux/mac/win and fyi waterfalls (https://cs.chromium.org/search/?q=webkit_python_tests+file:%5Esrc/testing/buildbot/).
,
Apr 19 2018
I believe the test has been failing since we enabled root-layer-scrolling (which changed the format for layer tree dump) in M66. Just examined the step on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/71519 and saw the test succeeded which I'm expecting to fail. This looks weird. I remember we ever ran the step on try bots. Can we bring it back? Is there any trybot current running the step?
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e862c1ad791bd91422ac4cb9ac638e00d89eb38 commit 0e862c1ad791bd91422ac4cb9ac638e00d89eb38 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Thu Apr 19 16:44:45 2018 [Layout-tests] Update repaint-overlay test expectation The new expectation is the new format of layer tree with root-layer-scrolling enabled which has been launched in M-66. Bug: 834722 Change-Id: Ie63af9eb10995bfac29ba65192afbfd268929337 Reviewed-on: https://chromium-review.googlesource.com/1019722 Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#552047} [modify] https://crrev.com/0e862c1ad791bd91422ac4cb9ac638e00d89eb38/third_party/WebKit/LayoutTests/paint/invalidation/repaint-overlay/layers-overlay.html
,
Apr 19 2018
The bots seem happy with the patch. It's still a mystery that the test passed on the bots before the CL. Filed bug 834989 for running webkit_python_tests on CQ bots. |
|||
►
Sign in to add a comment |
|||
Comment 1 by wangxianzhu@chromium.org
, Apr 19 2018Owner: wangxianzhu@chromium.org
Status: Assigned (was: Untriaged)