Switch Speech recognition to work with Audio service |
|||
Issue descriptionAudioInputController there should be replaced with AudioCaptureSource instance provided by Audio service client library.
,
Apr 19 2018
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68e948e58bf16ca64b90a4fcf9e51134f8c1f29a commit 68e948e58bf16ca64b90a4fcf9e51134f8c1f29a Author: Marina Ciocea <marinaciocea@chromium.org> Date: Thu May 10 22:26:17 2018 Switch speech recognition to using audio service input streams. Use audio service IPC instead of AudioInputController for creating input stream. This change is part of the effort of moving audio out of browser process [1]. By moving audio into a separate process, speech recognition can no longer use AudioInputController directly, and needs to use IPC to create and use input streams provided by audio service. [1] Chrome audio process design doc: http://doc/12vz7UZBQIp1195V-xAYvHIoQ1r536BCmMKcPN7Si-OI Bug: 834706 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1dc98ad670e1e9880320ae4bf054ae0d94f5b48f Reviewed-on: https://chromium-review.googlesource.com/1049685 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#557701} [modify] https://crrev.com/68e948e58bf16ca64b90a4fcf9e51134f8c1f29a/content/browser/browser_main_loop.cc [modify] https://crrev.com/68e948e58bf16ca64b90a4fcf9e51134f8c1f29a/content/browser/speech/speech_recognition_browsertest.cc [modify] https://crrev.com/68e948e58bf16ca64b90a4fcf9e51134f8c1f29a/content/browser/speech/speech_recognition_manager_impl.cc [modify] https://crrev.com/68e948e58bf16ca64b90a4fcf9e51134f8c1f29a/content/browser/speech/speech_recognition_manager_impl.h [modify] https://crrev.com/68e948e58bf16ca64b90a4fcf9e51134f8c1f29a/content/browser/speech/speech_recognizer_impl.cc [modify] https://crrev.com/68e948e58bf16ca64b90a4fcf9e51134f8c1f29a/content/browser/speech/speech_recognizer_impl.h [modify] https://crrev.com/68e948e58bf16ca64b90a4fcf9e51134f8c1f29a/content/browser/speech/speech_recognizer_impl_unittest.cc
,
Jun 1 2018
Nothing left to do here, right?
,
Jun 1 2018
No, it's fixed. |
|||
►
Sign in to add a comment |
|||
Comment 1 by olka@chromium.org
, Apr 19 2018