New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 834704 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 834702
issue 834706


Participants' hotlists:
Audio-Service


Sign in to add a comment

Implement AudioCaptureSource working on top of Audio service

Project Member Reported by olka@chromium.org, Apr 19 2018

Issue description

Audio service client library code to work on top of audio::mojom::InputStream and audio::mojom::StreamFactory.
 

Comment 1 by olka@chromium.org, Apr 19 2018

Blocking: 834702

Comment 2 by olka@chromium.org, Apr 19 2018

Blocking: 834706

Comment 3 by olka@chromium.org, Apr 19 2018

Summary: Implement AudioCaptureSource working on top of Audio service (was: Implement AudioCapturerSource working on top of Audio service)

Comment 4 by olka@chromium.org, Apr 25 2018

Cc: muyuanli@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfa60e517f22a75c8957fbe91f0fc674a0815d00

commit dfa60e517f22a75c8957fbe91f0fc674a0815d00
Author: Jonas Olsson <jonasolsson@chromium.org>
Date: Fri Apr 27 08:35:11 2018

Refactor session id handling in AudioinputDevice.

|session_id| used to be passed to AudioCapturerSource::Initialize, then on to AudioInputIPC::CreateStream, and finally into the stream creation callback.
Change that to pass it into AudioInputIPCFactory::CreateAudioInputIPC at AudioInputDevice creation time, and bind it into the callback at that point. We don't pass it to factory_->CreateAudioCapturerSource branch, as that one is only used for testing.

This means that the caller has to provide the session id at IPC creation time, instead of the call to Initialize.
Note that we currently don't currently support calling Initialize more than once, so we don't need to support changing the session_id later.

BUG= 834704 
TBR=bbudge@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ibfaaa80e1552e7166fc18b6c935ac1c03a2cef00
Reviewed-on: https://chromium-review.googlesource.com/1024170
Commit-Queue: Olga Sharonova <olka@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554339}
[modify] https://crrev.com/dfa60e517f22a75c8957fbe91f0fc674a0815d00/chrome/renderer/media/cast_receiver_session.cc
[modify] https://crrev.com/dfa60e517f22a75c8957fbe91f0fc674a0815d00/content/renderer/media/audio_device_factory.cc
[modify] https://crrev.com/dfa60e517f22a75c8957fbe91f0fc674a0815d00/content/renderer/media/audio_device_factory.h
[modify] https://crrev.com/dfa60e517f22a75c8957fbe91f0fc674a0815d00/content/renderer/media/audio_input_ipc_factory.cc
[modify] https://crrev.com/dfa60e517f22a75c8957fbe91f0fc674a0815d00/content/renderer/media/audio_input_ipc_factory.h
[modify] https://crrev.com/dfa60e517f22a75c8957fbe91f0fc674a0815d00/content/renderer/media/mock_audio_device_factory.h
[modify] https://crrev.com/dfa60e517f22a75c8957fbe91f0fc674a0815d00/content/renderer/media/mojo_audio_input_ipc.cc
[modify] https://crrev.com/dfa60e517f22a75c8957fbe91f0fc674a0815d00/content/renderer/media/mojo_audio_input_ipc.h
[modify] https://crrev.com/dfa60e517f22a75c8957fbe91f0fc674a0815d00/content/renderer/media/mojo_audio_input_ipc_unittest.cc
[modify] https://crrev.com/dfa60e517f22a75c8957fbe91f0fc674a0815d00/content/renderer/media/stream/external_media_stream_audio_source.cc
[modify] https://crrev.com/dfa60e517f22a75c8957fbe91f0fc674a0815d00/content/renderer/media/stream/local_media_stream_audio_source.cc
[modify] https://crrev.com/dfa60e517f22a75c8957fbe91f0fc674a0815d00/content/renderer/media/stream/processed_local_audio_source.cc
[modify] https://crrev.com/dfa60e517f22a75c8957fbe91f0fc674a0815d00/content/renderer/media/stream/processed_local_audio_source_unittest.cc
[modify] https://crrev.com/dfa60e517f22a75c8957fbe91f0fc674a0815d00/content/renderer/media/webrtc/rtc_peer_connection_handler_unittest.cc
[modify] https://crrev.com/dfa60e517f22a75c8957fbe91f0fc674a0815d00/content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc
[modify] https://crrev.com/dfa60e517f22a75c8957fbe91f0fc674a0815d00/content/renderer/pepper/pepper_platform_audio_input.cc
[modify] https://crrev.com/dfa60e517f22a75c8957fbe91f0fc674a0815d00/content/renderer/pepper/pepper_platform_audio_input.h
[modify] https://crrev.com/dfa60e517f22a75c8957fbe91f0fc674a0815d00/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/dfa60e517f22a75c8957fbe91f0fc674a0815d00/media/audio/audio_input_device.cc
[modify] https://crrev.com/dfa60e517f22a75c8957fbe91f0fc674a0815d00/media/audio/audio_input_device.h
[modify] https://crrev.com/dfa60e517f22a75c8957fbe91f0fc674a0815d00/media/audio/audio_input_device_unittest.cc
[modify] https://crrev.com/dfa60e517f22a75c8957fbe91f0fc674a0815d00/media/audio/audio_input_ipc.h
[modify] https://crrev.com/dfa60e517f22a75c8957fbe91f0fc674a0815d00/media/base/audio_capturer_source.h

Labels: M-70
Labels: -M-70 M-68
Status: Fixed (was: Assigned)

Sign in to add a comment