New issue
Advanced search Search tips

Issue 834703 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

mus_browser_tests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Apr 19 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of mstensho@chromium.org

mus_browser_tests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1)

Builders failed on: 
- Linux Chromium OS ASan LSan Tests (1): 
  https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29


 

Comment 1 Deleted

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9a85aaacf84490c55e5e6d9677499dac1b49e77

commit e9a85aaacf84490c55e5e6d9677499dac1b49e77
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Thu Apr 19 11:42:12 2018

Disable SamlTest.ScrapedMultiple due to flakiness.

TBR=xiyuan@chromium.org

Bug: 834703
Change-Id: Iac81e8e96411237ee761691cb3c569138a8d5aa5
Reviewed-on: https://chromium-review.googlesource.com/1019140
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551983}
[modify] https://crrev.com/e9a85aaacf84490c55e5e6d9677499dac1b49e77/chrome/browser/chromeos/login/saml/saml_browsertest.cc

Labels: -Sheriff-Chromium
Owner: xiy...@chromium.org
Status: Assigned (was: Available)

Comment 5 by xiy...@chromium.org, Apr 19 2018

Cc: xiy...@chromium.org
Owner: r...@chromium.org
rkc@, could you help to find an owner for this since I probably would not be able to get this for a while?

I am not sure why the test failed though. From the log, it seems that we have passed SamlAuth and user session is started:

127.0.0.1 - - [19/Apr/2018 02:33:43] "POST /SAMLAuth HTTP/1.1" 307 -
[30537:30843:0419/023343.379664:WARNING:fake_gaia.cc(319)] Serving request /SSO
127.0.0.1 - - [19/Apr/2018 02:33:43] "POST /SSO?SAMLResponse=fake_response&RelayState=https%3A%2F%2Faccounts.google.com%3A42894%2FDummySAMLContinue HTTP/1.1" 307 -
[30537:30843:0419/023343.568231:WARNING:fake_gaia.cc(319)] Serving request /DummySAMLContinue
127.0.0.1 - - [19/Apr/2018 02:33:43] "POST /DummySAMLContinue HTTP/1.1" 200 -
==> This shows that we hit Saml IdP page and passed the Saml auth.

[30537:30537:0419/023343.895061:INFO:signin_screen_handler.cc(1473)] Login WebUI >> active: 0, source: gaia-signin
[30537:30537:0419/023345.083797:INFO:signin_screen_handler.cc(1473)] Login WebUI >> active: 1, source: gaia-signin
[30537:30537:0419/023345.667458:INFO:signin_screen_handler.cc(1473)] Login WebUI >> active: 0, source: gaia-signin
[30537:30537:0419/023346.614968:INFO:signin_screen_handler.cc(1473)] Login WebUI >> active: 1, source: gaia-signin

==> Gaia screen hide and show twice because the test would show the password confirm screen and hide Gaia twice.

[30537:30843:0419/023346.707957:WARNING:fake_gaia.cc(319)] Serving request /oauth2/v4/token
127.0.0.1 - - [19/Apr/2018 02:33:46] "POST /oauth2/v4/token HTTP/1.1" 200 -
[30537:30537:0419/023346.730810:ERROR:gaia_auth_fetcher.cc(71)] Missing ID token on refresh token fetch response.
[30537:30537:0419/023346.732096:ERROR:device_event_log_impl.cc(156)] [02:33:46.732] Login: cryptohome_util.cc:131 GetKeyDataEx failed with no GetKeyDataReply extension in reply.

==> The crypthome_util.cc log is from updating easy unlock keys after user sign-in.

And this point, user session should be starting. And the test just waits for NOTIFICATION_SESSION_STARTED. Not sure why it would fail.

Maybe because it is an ASAN bot and we exceeds the max allowed time out?

Comment 6 by emaxx@chromium.org, May 4 2018

Cc: emaxx@chromium.org
There's a bunch of other tests in this file which were disabled on ASan/LSan -  presumably, due to being too slow (e.g., SamlTest.ScrapedDynamic, SAMLEnrollmentTest.WithoutCredentialsPassingAPI).
I think we should make SamlTest.ScrapedMultiple also disabled *only* in this configuration, instead of disabling it uniformly. It's a bit scary to lose the test coverage in this important area of SAML login.
Cc: jdufault@chromium.org achuith@chromium.org alemate@chromium.org
 Issue 759291  has been merged into this issue.

Comment 8 by rkc@google.com, Jan 17 (6 days ago)

Owner: atwilson@chromium.org

Comment 9 by mstensho@chromium.org, Jan 17 (6 days ago)

Cc: -mstensho@chromium.org

Sign in to add a comment