New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 834689 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

buffered_frame_deserializer_fuzzer fails to link in ASan builds

Project Member Reported by h...@chromium.org, Apr 19 2018

Issue description

For example, here: https://ci.chromium.org/buildbot/chromium.clang/ToTLinuxASanLibfuzzer/767

It regressed in this commit: https://chromium-review.googlesource.com/1015189

The target is probably just missing a dependency on //build/config:exe_and_shlib_deps
 

Comment 1 by h...@chromium.org, Apr 19 2018

> The target is probably just missing a dependency on //build/config:exe_and_shlib_deps

Which in perfetto comes via gn:default_deps

Comment 2 by h...@chromium.org, Apr 19 2018

Strange, buffered_frame_deserializer_fuzzer does depend on gn:default_deps already..

Comment 3 by h...@chromium.org, Apr 19 2018

Actually, no ASan necessary; it just doesn't build at all:

$ gn gen --args="use_libfuzzer = true" out/release && ninja -C out/release buffered_frame_deserializer_fuzzer
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c19f1902c39e5ce0c959c285895ad9434d71c0b

commit 6c19f1902c39e5ce0c959c285895ad9434d71c0b
Author: Hans Wennborg <hans@chromium.org>
Date: Thu Apr 19 12:26:46 2018

Revert "Reland "Add a Mojo-based transportation layer for Perfetto""

This reverts commit 62436735e211820d7e63fe9c755be609b8a390d5.

Reason for revert:
buffered_frame_deserializer_fuzzer doesn't build, see  crbug.com/834689 

Original change's description:
> Reland "Add a Mojo-based transportation layer for Perfetto"
> 
> This is a reland of 4df8a2dd8f3b875773af061c1cbdcc519d19b283
> 
> Original change's description:
> > Add a Mojo-based transportation layer for Perfetto
> >
> > This adds a base layer that individual logging protocols (like tracing)
> > can use to send their data to Perfetto, using Mojo messaging and
> > shared memory.
> >
> > First CL of several, after this comes the Chrome tracing layer: https://chromium-review.googlesource.com/c/chromium/src/+/981270
> >
> > A preview of the full integration can be seen here: https://chromium-review.googlesource.com/c/chromium/src/+/852808
> >
> > The design doc for the integration: https://docs.google.com/document/d/1a8lvN3zYWEyAsBjtuRRsy0fWOWdUdbw6bGnKLBscGdw/edit
> >
> > R=primiano@chromium.org,skyostil@chromium.org
> >
> > Change-Id: Ie1db5745ebffdcf1e2d74e2f6b12395f447c8552
> > Reviewed-on: https://chromium-review.googlesource.com/980578
> > Reviewed-by: oysteine <oysteine@google.com>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Primiano Tucci <primiano@chromium.org>
> > Commit-Queue: oysteine <oysteine@google.com>
> > Cr-Commit-Position: refs/heads/master@{#551019}
> 
> Change-Id: Ic47afdb6c2e09924a5f540fa56552ceb6e29e6d7
> 
> TBR=dcheng@chromium.org,primiano@chromium.org,oysteine@google.com,skyostil@chromium.org
> 
> Change-Id: Ic47afdb6c2e09924a5f540fa56552ceb6e29e6d7
> Reviewed-on: https://chromium-review.googlesource.com/1015189
> Reviewed-by: oysteine <oysteine@chromium.org>
> Commit-Queue: oysteine <oysteine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551526}

TBR=dcheng@chromium.org,primiano@chromium.org,oysteine@chromium.org,skyostil@chromium.org
Bug:  834689 

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ia7bcfabbace35f0a2221cc526d6b710d2caa86d8
Reviewed-on: https://chromium-review.googlesource.com/1019200
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551989}
[modify] https://crrev.com/6c19f1902c39e5ce0c959c285895ad9434d71c0b/DEPS
[modify] https://crrev.com/6c19f1902c39e5ce0c959c285895ad9434d71c0b/services/tracing/BUILD.gn
[modify] https://crrev.com/6c19f1902c39e5ce0c959c285895ad9434d71c0b/services/tracing/DEPS
[modify] https://crrev.com/6c19f1902c39e5ce0c959c285895ad9434d71c0b/services/tracing/manifest.json
[delete] https://crrev.com/0e98cd744c61c76de1914fc85171ae51b0bfba2f/services/tracing/perfetto/perfetto_integration_unittest.cc
[delete] https://crrev.com/0e98cd744c61c76de1914fc85171ae51b0bfba2f/services/tracing/perfetto/perfetto_service.cc
[delete] https://crrev.com/0e98cd744c61c76de1914fc85171ae51b0bfba2f/services/tracing/perfetto/perfetto_service.h
[delete] https://crrev.com/0e98cd744c61c76de1914fc85171ae51b0bfba2f/services/tracing/perfetto/producer_host.cc
[delete] https://crrev.com/0e98cd744c61c76de1914fc85171ae51b0bfba2f/services/tracing/perfetto/producer_host.h
[modify] https://crrev.com/6c19f1902c39e5ce0c959c285895ad9434d71c0b/services/tracing/public/cpp/BUILD.gn
[delete] https://crrev.com/0e98cd744c61c76de1914fc85171ae51b0bfba2f/services/tracing/public/cpp/perfetto/producer_client.cc
[delete] https://crrev.com/0e98cd744c61c76de1914fc85171ae51b0bfba2f/services/tracing/public/cpp/perfetto/producer_client.h
[delete] https://crrev.com/0e98cd744c61c76de1914fc85171ae51b0bfba2f/services/tracing/public/cpp/perfetto/shared_memory.cc
[delete] https://crrev.com/0e98cd744c61c76de1914fc85171ae51b0bfba2f/services/tracing/public/cpp/perfetto/shared_memory.h
[delete] https://crrev.com/0e98cd744c61c76de1914fc85171ae51b0bfba2f/services/tracing/public/cpp/perfetto/task_runner.cc
[delete] https://crrev.com/0e98cd744c61c76de1914fc85171ae51b0bfba2f/services/tracing/public/cpp/perfetto/task_runner.h
[delete] https://crrev.com/0e98cd744c61c76de1914fc85171ae51b0bfba2f/services/tracing/public/cpp/tracing_features.cc
[delete] https://crrev.com/0e98cd744c61c76de1914fc85171ae51b0bfba2f/services/tracing/public/cpp/tracing_features.h
[modify] https://crrev.com/6c19f1902c39e5ce0c959c285895ad9434d71c0b/services/tracing/public/mojom/BUILD.gn
[delete] https://crrev.com/0e98cd744c61c76de1914fc85171ae51b0bfba2f/services/tracing/public/mojom/perfetto_service.mojom

Uh strange. The thing I cannot understand is: how come chromium's build picks up the buffered_frame_deserializer_fuzzer traget.
No chromium GN file depends on that.
I guess gn just builds all target in a GN file if there is at least one dependency to one target to the same gn file.

We should either mask out that target with is_chromium_build or figure out how to make it build in chromium

Comment 7 by r...@chromium.org, Apr 19 2018

Cc: thomasanderson@chromium.org glider@chromium.org p...@chromium.org ruiu@google.com
 Issue 834463  has been merged into this issue.
Status: Fixed (was: Assigned)
Marking as fixed as the CL has been reverted.

Comment 9 by r...@chromium.org, Apr 19 2018

I am still waiting for this build to come back green, but it probably will soon:
https://ci.chromium.org/buildbot/chromium.clang/ToTLinuxASanLibfuzzer/782
Relanding in https://chromium-review.googlesource.com/c/chromium/src/+/1019619 with DEPDS rolled to a rev of Perfetto which excludes the libfuzzer targets.

Sign in to add a comment