New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 834682 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Participants' hotlists:
Launcher-A11y
Launcher-Polish


Sign in to add a comment

Non-Regression: Unnecessary flickering of Search box is seen in docked region while we Drag an app into another app in App Launcher

Project Member Reported by rkalavakuntla@chromium.org, Apr 19 2018

Issue description

Chrome Version:67.0.3396.12/10575.8.0 dev channel Daisy,Candy,Reks
OS: Chrome OS

What steps will reproduce the problem?
(1)Sign into user >> Enable Docked Magnifier from Ubertray/Accessibility
(2)Open App Launcher >>Drag an app into another app to make a folder and observe the docked region while dragging an app

Actual: Unnecessary flickering of Search box is seen in docked region while we Drag an app into another app
Expected: No such unwanted flickering of Search box should be seen in docked region while we Drag an app into another app

This is a Non-Regression issue seen from M-66

Note: Issue is not seen in Linux,Windows OS 

Attached the screencast for reference..

@newcomer : please confirm the issue.
 
Actual flickering.mp4
15.7 MB Download

Comment 1 Deleted

Cc: newcomer@chromium.org afakhry@chromium.org
Status: Started (was: Assigned)
afakhry@, Does the magnifying window place itself based on view focus? 
Yes, the docked magnifier should center itself around the focused view. See https://cs.chromium.org/chromium/src/ash/accelerators/ash_focus_manager_factory.cc?q=AshFocusManagerFactory::Delegate::OnDidChangeFocus&sq=package:chromium&l=38

Maybe we could do things differently when drag and drop is in progress for example?


Afakhry@ any idea on a priority for this? 
Cc: lpalmaro@chromium.org
I'd leave it at P2. +lpalmaro if she thinks otherwise.

Does it help if we skip notifying the magnifiers if a drag and drop is in progress like this:?

  aura::client::DragDropClient* drag_drop_client =
      aura::client::GetDragDropClient(view's window);
  if (drag_drop_client && drag_drop_client->IsDragDropInProgress())
    return;

Does it work?
Components: UI>Shell>Launcher
Labels: M-71
Owner: ----
Unassigned for triage.
Owner: weidongg@chromium.org
Status: Assigned (was: Started)
->> weidongg as the owner of Launcher nowadays.
Cc: weidongg@chromium.org
Owner: ----
Status: Untriaged (was: Assigned)
Per newcomer@, this should remain on the Launcher team's backlog for now.
Status: Available (was: Untriaged)
I'm not able to reproduce this in 71. Are you still seeing this? 
Labels: -M-67
Labels: -M-71
This does repro on 71 even when just dragging full screen launcher down. Moving it higher in the hotlist.
This happens because search box by default has the focus even when an item is being dragged. This issue does not exist if you shift focus to other views. It might be solved if we set the focus to dragged view in dragging.
Owner: ginko@chromium.org
Labels: M-74
Status: Assigned (was: Available)

Sign in to add a comment