Non-Regression: Unnecessary flickering of Search box is seen in docked region while we Drag an app into another app in App Launcher |
||||||||||||||
Issue descriptionChrome Version:67.0.3396.12/10575.8.0 dev channel Daisy,Candy,Reks OS: Chrome OS What steps will reproduce the problem? (1)Sign into user >> Enable Docked Magnifier from Ubertray/Accessibility (2)Open App Launcher >>Drag an app into another app to make a folder and observe the docked region while dragging an app Actual: Unnecessary flickering of Search box is seen in docked region while we Drag an app into another app Expected: No such unwanted flickering of Search box should be seen in docked region while we Drag an app into another app This is a Non-Regression issue seen from M-66 Note: Issue is not seen in Linux,Windows OS Attached the screencast for reference.. @newcomer : please confirm the issue.
,
Apr 24 2018
afakhry@, Does the magnifying window place itself based on view focus?
,
Apr 24 2018
Yes, the docked magnifier should center itself around the focused view. See https://cs.chromium.org/chromium/src/ash/accelerators/ash_focus_manager_factory.cc?q=AshFocusManagerFactory::Delegate::OnDidChangeFocus&sq=package:chromium&l=38 Maybe we could do things differently when drag and drop is in progress for example?
,
Apr 26 2018
Afakhry@ any idea on a priority for this?
,
Apr 26 2018
I'd leave it at P2. +lpalmaro if she thinks otherwise.
Does it help if we skip notifying the magnifiers if a drag and drop is in progress like this:?
aura::client::DragDropClient* drag_drop_client =
aura::client::GetDragDropClient(view's window);
if (drag_drop_client && drag_drop_client->IsDragDropInProgress())
return;
Does it work?
,
Jul 27
,
Aug 7
,
Sep 25
Unassigned for triage.
,
Sep 25
->> weidongg as the owner of Launcher nowadays.
,
Sep 25
Per newcomer@, this should remain on the Launcher team's backlog for now.
,
Sep 27
,
Oct 5
I'm not able to reproduce this in 71. Are you still seeing this?
,
Oct 5
,
Oct 5
,
Oct 5
This does repro on 71 even when just dragging full screen launcher down. Moving it higher in the hotlist.
,
Oct 6
This happens because search box by default has the focus even when an item is being dragged. This issue does not exist if you shift focus to other views. It might be solved if we set the focus to dragged view in dragging.
,
Dec 14
,
Dec 15
,
Dec 19
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 Deleted