New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 834666 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
OOO Dec 22 - Jan 8
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Feature

Blocked on:
issue 647200
issue 824019
issue 828868

Blocking:
issue 672469


Participants' hotlists:
Audio-Service


Sign in to add a comment

Do not instantiate AudioManager in BrowserMainLoop when running Audio service out of process

Project Member Reported by olka@chromium.org, Apr 19 2018

Issue description

Should be done as soon as all the dependencies on AudioManager are removed from content.
 

Comment 1 by olka@chromium.org, Apr 19 2018

Labels: -Type-Bug Type-Feature

Comment 2 by olka@chromium.org, Apr 19 2018

Blocking: 832666

Comment 3 by olka@chromium.org, Apr 19 2018

Blocking: -832666

Comment 4 by olka@chromium.org, Apr 19 2018

Blocking: 672469

Comment 5 by olka@chromium.org, Apr 19 2018

Blockedon: 824019

Comment 6 by olka@chromium.org, Apr 19 2018

Blockedon: 828868

Comment 7 by olka@chromium.org, Apr 19 2018

Blockedon: 647200
Project Member

Comment 8 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57964cb79b81217b8c6d0cb2234b79119b7b66a4

commit 57964cb79b81217b8c6d0cb2234b79119b7b66a4
Author: Olga Sharonova <olka@chromium.org>
Date: Thu May 17 11:08:00 2018

Do not instantiate AudioManager when running Audio service out of process

Do not instantiate AudioManager in BrowserMainLoop when running
Audio service out of process.

Audio service DD: https://docs.google.com/document/d/1s_Fd1WRDdpb5n6C2MSJjeC3fis6hULZwfKMeDd4K5tI/edit#

Dry runs with out of process audio service are here:
https://chromium-review.googlesource.com/c/chromium/src/+/1057807

Bug:  834666 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ia957b6209007413faad575d2410bdbba3ded5728
Reviewed-on: https://chromium-review.googlesource.com/1057624
Commit-Queue: Olga Sharonova <olka@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559490}
[modify] https://crrev.com/57964cb79b81217b8c6d0cb2234b79119b7b66a4/chrome/browser/media/webrtc/webrtc_text_log_handler.cc
[modify] https://crrev.com/57964cb79b81217b8c6d0cb2234b79119b7b66a4/chromecast/browser/cast_content_browser_client.cc
[modify] https://crrev.com/57964cb79b81217b8c6d0cb2234b79119b7b66a4/chromecast/browser/cast_content_browser_client.h
[modify] https://crrev.com/57964cb79b81217b8c6d0cb2234b79119b7b66a4/content/browser/browser_main_loop.cc
[modify] https://crrev.com/57964cb79b81217b8c6d0cb2234b79119b7b66a4/content/browser/browser_main_loop.h
[modify] https://crrev.com/57964cb79b81217b8c6d0cb2234b79119b7b66a4/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/57964cb79b81217b8c6d0cb2234b79119b7b66a4/content/browser/renderer_host/media/media_stream_manager.cc
[modify] https://crrev.com/57964cb79b81217b8c6d0cb2234b79119b7b66a4/content/browser/renderer_host/media/media_stream_manager.h
[modify] https://crrev.com/57964cb79b81217b8c6d0cb2234b79119b7b66a4/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/57964cb79b81217b8c6d0cb2234b79119b7b66a4/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/57964cb79b81217b8c6d0cb2234b79119b7b66a4/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/57964cb79b81217b8c6d0cb2234b79119b7b66a4/content/public/browser/content_browser_client.h
[modify] https://crrev.com/57964cb79b81217b8c6d0cb2234b79119b7b66a4/media/audio/audio_thread_impl.cc

Comment 9 by olka@chromium.org, May 29 2018

Status: Fixed (was: Assigned)
[bulk-edit: disregard if N/A] Can the owner please set milestone to this bug if applicable?

Sign in to add a comment