Keyboard Shortcut for Chrome Extensions does not work (Alt+Shift+Up arrow or Down arrow) |
||||||
Issue descriptionChrome Version: 66.0.3359.117 (Official Build) beta (64-bit) Chrome OS Version: 10452.69.0 (Official Build) beta-channel eve Chrome OS Platform: Pixelbook <b>Network info: <network, encryption type, router model (if known)></b> Please specify Cr-* of the system to which this bug/feature applies (add the label below). Steps To Reproduce: (1) Navigate to chrome://extensions/shortcuts (2) Try to set one of the following keyboard shortcut for any extension 'Alt + Shift + Up Arrow' 'Alt + Shift + Down Arrow' Expected Result: Keyboard shortcut is accepted. Actual Result: Input field is cleared and shortcut not accepted How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Always What is the impact to the user, and is there a workaround? If so, what is it? Workaround is using another shortcut, but it breaks the workflow of users that have been using those shortcuts until now. Please provide any additional information below. Attach a screen shot or log if possible. It has been working on multiple devices since at least Q3 2017 Switched to a Pixelbook on April 2018 and is not working. Other co-workers are able to reproduce with their accounts on Pixelbooks and HP Chromebooks. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Aug 20
Hi afakhry@, could you please find some one who can look this? Thanks.
,
Aug 21
andrewxu@ Let's discuss when I'm back from OOO. In the meantime, try to take a look. If you have questions, please ask Oshima@.
,
Aug 22
It is caused by event rewriting (https://cs.chromium.org/chromium/src/ui/chromeos/events/event_rewriter_chromeos.cc?q=kNonSearchRemappings&g=0&l=978): Alt + Up will be rewritten to PageUp. As result, function hasModifier in shortcut_util.js will return false. So what should I do to deal with it? Does it act as expected?
,
Aug 22
It seems strange that the event is rewritten prior to determining what will handle the event (we specifically disable shortcut handling while the user is entering keys in order to avoid most things being handled). Is there a reason it has to happen so early?
,
Aug 22
Re #5: That's how event rewriting works. The keys are rewritten very early before they're delivered to simulate the condition as if the re-written-to key is the one invoked in the first place.
,
Aug 22
Hmm... :/ that seems like it will make it fundamentally very difficult to handle custom keybindings. We could hypothetically have a special reverse-mapping so that we could tell on CrOS if a single key event is triggered through a key chord, but that sounds exceedingly fragile, and quite possibly different per-device.
,
Aug 22
I'm not sure why we still keep those Alt-based remappings [1] while we also have equivalent search-based remappings [2]. Even the Search-based remappings can cause problems, See issue 852066. +abodenha@ and +tbuckley@ if they know any history why we have both. [1]: https://cs.chromium.org/chromium/src/ui/chromeos/events/event_rewriter_chromeos.cc?q=kNonSearchRemappings&g=0&l=971 [2]: https://cs.chromium.org/chromium/src/ui/chromeos/events/event_rewriter_chromeos.cc?q=kSearchRemappings&g=0&l=939
,
Aug 22
Also +vapier@ for a related CL he sent a while ago.
,
Aug 22
we should delete these shortcuts from CrOS imo as i suggested in issue 811344. that'd resolve this bug as well. this follows our policy as well: go/cros-hotkey.
,
Sep 29
I just wanted to add that it's ideal for some functionality like window tiling, to use the arrow keys instead of letters. Alt+Shift is the only combination in CrOS that currently doesn't use any of the 4 arrow keys, and that's why it was used for this kind of extensions. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by afakhry@chromium.org
, Apr 19 2018Components: UI>Browser>ExtensionsManagement UI>Input>KeyboardShortcuts
Labels: -Pri-3 Pri-2
Owner: wutao@chromium.org
Status: Assigned (was: Unconfirmed)