Issue metadata
Sign in to add a comment
|
Variable race condition in Vaapi VDA |
||||||||||||||||||||||||
Issue descriptionA Variable must be read and written by a specified thread. Otherwise, it must be guarded by lock. Vaapi breaks this rule about some variable. It would cause a race condition. For example, awaiting_va_surfaces_recycle_ is written by decoder_thread_ and VDA client thread. https://cs.chromium.org/chromium/src/media/gpu/vaapi/vaapi_video_decode_accelerator.cc?q=vaapi_video_decode_accelerator.cc&sq=package:chromium&dr&l=372 https://cs.chromium.org/chromium/src/media/gpu/vaapi/vaapi_video_decode_accelerator.cc?q=vaapi_video_decode_accelerator.cc&sq=package:chromium&dr&l=435
,
Apr 19 2018
mcasas@, could you take a look. The race condition in the above example was introduced by your change. https://chromium-review.googlesource.com/c/chromium/src/+/973684 There may be some other race conditions. We need to fix them if there. Thanks in advance.
,
Apr 19 2018
M67 branched a week ago. Does the revert have conflict? If not, we should revert and merge it to m67.
,
Apr 19 2018
,
Apr 19 2018
,
Jul 4
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by posciak@chromium.org
, Apr 19 2018Labels: videoshortlist