New issue
Advanced search Search tips

Issue 834656 link

Starred by 1 user
Status: Fixed
Owner:
kkinnu...@nvidia.com
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

depot_tools package_toolchain.py fails with VS 2017 15.6.6

Project Member Reported by kkinnu...@nvidia.com, Apr 19 2018 
depot_tools package_toolchain.py fails with VS 2017 15.6.6

C:\Users\kkinnunen>\depot_tools\python \depot_tools\win_toolchain\package_from_installed.py -w 10.0.15063.0 2017
Building file list for VS 2017 Windows 10.0.15063.0...
C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\IDE\CommonExtensions\Microsoft\TestWindow\Extensions\CppUnitFramework\x64\dbghelp.dll does not exist.

C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\IDE\CommonExtensions\Microsoft\TestWindow\Extensions\CppUnitFramework\x64\dbghelp.dll does not exist.

C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\IDE\CommonExtensions\Microsoft\TestWindow\Extensions\CppUnitFramework\dbghelp.dll does not exist.

C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\IDE\CommonExtensions\Microsoft\TestWindow\Extensions\CppUnitFramework\dbghelp.dll does not exist.

9179/9180 ...\appdata\local\temp\tmpejhcuz\VS_VERSIONTraceback (most recent call last):
  File "\depot_tools\win_toolchain\package_from_installed.py", line 499, in <module>
    sys.exit(main())
  File "\depot_tools\win_toolchain\package_from_installed.py", line 487, in main
    raise Exception('One or more files were missing - aborting')
Exception: One or more files were missing - aborting



The 15.6.6 VS 2017 needs to be used, as normal users do not seem to be able to download anything else.

Comment 1 by kkinnu...@nvidia.com, Apr 19 2018

Description: Show this description

Comment 2 Deleted

Project Member

Comment 3 by bugdroid1@chromium.org, May 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/d3f2c8e7834616e48fbe7cef9286029361b043c5

commit d3f2c8e7834616e48fbe7cef9286029361b043c5
Author: Kimmo Kinnunen <kkinnunen@nvidia.com>
Date: Thu May 10 15:39:25 2018

win_toolchain: Add another source dir for dbghelp.dll when packaging the toolchain

It appears that newer VS 2017 installers install CppUnitFramework in different
way. My version VS 15.6.6. The problem is that normal users do not seem to be
able to download the VS 15.3.2 that Chromium suggests and this script was
probably originally tested with.

I installed:
vs_professional__428566190.xxx.exe
  --add Microsoft.VisualStudio.Workload.NativeDesktop
  --add Microsoft.VisualStudio.Component.Debugger.JustInTime
  --add Microsoft.VisualStudio.Component.Graphics.Tools
  --add Microsoft.VisualStudio.Component.Graphics.Win81
  --add Microsoft.VisualStudio.Component.NuGet
  --add Microsoft.VisualStudio.Component.Static.Analysis.Tools
  --add Microsoft.VisualStudio.Component.VC.ATL
  --add Microsoft.VisualStudio.Component.VC.DiagnosticTools
  --add Microsoft.VisualStudio.Component.VC.TestAdapterForGoogleTest
  --add Microsoft.VisualStudio.Component.VC.Tools.x86.x64
  --add Microsoft.VisualStudio.Component.Windows10SDK.15063.Desktop
  --add Microsoft.VisualStudio.Component.Windows10SDK.15063.UWP
  --add Microsoft.VisualStudio.Component.Windows10SDK.15063.UWP.Native

 Go to apps -> Windows sdk 15063
  Modify  -> Change
   Select Debugging tools for Windows

Ended up with VS 15.6.6 and Windows SDK 10.0.15063.673

Packaged with:
  python  %HOME%\depot_tools\win_toolchain\package_from_installed.py -w 10.0.15063.0 2017

Bug:  834656 
Change-Id: I5e6bf6a5f94a28d5ba81a3c8cd79e37028b9429b
Reviewed-on: https://chromium-review.googlesource.com/1018470
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>

[modify] https://crrev.com/d3f2c8e7834616e48fbe7cef9286029361b043c5/win_toolchain/package_from_installed.py
Project Member

Comment 4 by bugdroid1@chromium.org, May 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64a7279c9be3a6d37ed2528c79e3ab662a40d5af

commit 64a7279c9be3a6d37ed2528c79e3ab662a40d5af
Author: depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu May 10 16:55:31 2018

Roll src/third_party/depot_tools/ 7c3ff1311..d3f2c8e78 (1 commit)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7c3ff1311a45..d3f2c8e78346

$ git log 7c3ff1311..d3f2c8e78 --date=short --no-merges --format='%ad %ae %s'
2018-04-26 kkinnunen win_toolchain: Add another source dir for dbghelp.dll when packaging the toolchain

Created with:
  roll-dep src/third_party/depot_tools
BUG= chromium:834656 


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I73791492e502ea9d0dca607a646154eecdf735d9
Reviewed-on: https://chromium-review.googlesource.com/1053762
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557557}
[modify] https://crrev.com/64a7279c9be3a6d37ed2528c79e3ab662a40d5af/DEPS

Comment 5 by kkinnu...@nvidia.com, May 11 2018

Owner: kkinnu...@nvidia.com
Status: Fixed (was: Untriaged)
►

Sign in to add a comment