Regression:Sad face icon is seen Blank in tab's title bar when tab is crashed.
Reported by
shruti.j...@etouch.net,
Apr 19 2018
|
|||
Issue descriptionChrome version :68.0.3400.0 (Official Build) Revision 9f775bf70a07668811dfc3b55bbd2e5f9c910fd0-refs/heads/master@{#551875}(64-bit) OS : MAC(10.12.6,10.13.1,10.13.5) OS. Steps to reproduce: 1.Launch chrome and navigate to New incognito window from wrench menu. 2.Open NTP, type chrome://kill in omnibox and hit Enter. Actual Result : Sad face icon is seen Blank in tab's title bar when tab is crashed. Expected Result :Sad face icon is seen Blank in tab's title bar when tab is crashed. Bisect info: This is regression issue broken in ‘M-67’ and providing bisect info below (Unable to provide bisect using per-revision script,Hence providing bisect with old script): Good Build: 67.0.3390.0(Revision:548637) Bad Build: 67.0.3393.0(Revision:549377) Narrow Bisect info : https://chromium.googlesource.com/chromium/src/+log/e893d0e2a8c5711ffeba045decce0b4e0363c103..2050d71b0b5731fa3d0cc645845d889cbbe600dd?pretty=fuller&n=10000 Suspecting: r548637 @Peter Boström : Could you please help to reassign if your change is not the cause for this change. Note:Issue is not seen on Windows and Linux OS. Thank You!
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1aa0ce833c70d90f590d8682600b8c12e492b751 commit 1aa0ce833c70d90f590d8682600b8c12e492b751 Author: Peter Boström <pbos@chromium.org> Date: Tue Apr 24 00:41:48 2018 Use transparent smiley for sad-tab favicon Previous version had white "=(" which wouldn't work well for incognito after tinting to white (smiley and folder would both be white-ish). With a transparent smiley the underlying dark-grey tab renders through as dark eyes for a light-grey folder. Bug: chromium:834645 Change-Id: I1c4f80004ee7a7227fef231d9b136a4a8c5ee566 Reviewed-on: https://chromium-review.googlesource.com/1022744 Reviewed-by: Scott Graham <scottmg@chromium.org> Reviewed-by: Cait Phillips <caitkp@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#552927} [modify] https://crrev.com/1aa0ce833c70d90f590d8682600b8c12e492b751/components/resources/default_100_percent/crash/favicon_sad_tab.png [modify] https://crrev.com/1aa0ce833c70d90f590d8682600b8c12e492b751/components/resources/default_200_percent/crash/favicon_sad_tab.png [modify] https://crrev.com/1aa0ce833c70d90f590d8682600b8c12e492b751/components/resources/default_300_percent/crash/favicon_sad_tab.png
,
Apr 24 2018
Update : Retested above issue on Windows (7,8,8.1,10) Linux(14.04 LTS) and Mac(10.12.6,10.13.1,10.13.5) OS using latest Canary #68.0.3405.0 and issue is fixed. Sad Face favicon icon is seen properly .Kindly review the attached screen-cast. Thank you!
,
Apr 24 2018
Thanks! I don't think this needs to be merged to 67 as it's going to beta fairly soon. |
|||
►
Sign in to add a comment |
|||
Comment 1 by pbos@chromium.org
, Apr 19 2018Status: Started (was: Assigned)