New issue
Advanced search Search tips

Issue 834633 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Timeout in pdf_codec_fax_fuzzer

Project Member Reported by ClusterFuzz, Apr 19 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6580562035474432

Fuzzer: libFuzzer_pdf_codec_fax_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Timeout (exceeds 25 secs)
Crash Address: 
Crash State:
  pdf_codec_fax_fuzzer
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=453381:453413

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6580562035474432

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Apr 19 2018

Components: Internals>Plugins>PDF
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Cc: thestig@chromium.org
Project Member

Comment 3 by ClusterFuzz, Apr 26 2018

Labels: OS-Mac
Owner: rharrison@chromium.org
Status: Assigned (was: Untriaged)
rharrison@ image decoder fun ....
Cc: -thestig@chromium.org rharrison@chromium.org
Owner: thestig@chromium.org
I forgot to assign this one to myself last week.
Project Member

Comment 6 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/12401f7d2dab48cc01387c58636c2e93db9c738d

commit 12401f7d2dab48cc01387c58636c2e93db9c738d
Author: Lei Zhang <thestig@chromium.org>
Date: Tue May 15 01:36:51 2018

Read data in bigger chunks in fax codec code.

In case there are long runs of data to be skipped, FindBit() runs much
faster reading and comparing 8 bytes at a time.

BUG= chromium:834633 

Change-Id: Ifc7b348d123c5a72cf09fbf53d764075f8abfba0
Reviewed-on: https://pdfium-review.googlesource.com/32513
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>

[modify] https://crrev.com/12401f7d2dab48cc01387c58636c2e93db9c738d/core/fxcodec/codec/fx_codec_fax.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/473b4ae489e8c6d63b087693589eda03399f60f6

commit 473b4ae489e8c6d63b087693589eda03399f60f6
Author: Lei Zhang <thestig@chromium.org>
Date: Tue May 15 01:41:39 2018

Lower the limit of image dimensions for fax codecs.

Use the same limit as JBIG2 codecs.

BUG= chromium:834633 

Change-Id: I11d12c841e10ab48fd85df792bf8a034fe40493c
Reviewed-on: https://pdfium-review.googlesource.com/32514
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>

[modify] https://crrev.com/473b4ae489e8c6d63b087693589eda03399f60f6/core/fxcodec/codec/fx_codec_fax.cpp

Status: Fixed (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9696714ad13594ba58ec7842c2df39bd0f622017

commit 9696714ad13594ba58ec7842c2df39bd0f622017
Author: pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue May 15 07:13:30 2018

Roll src/third_party/pdfium/ 08d96f1ca..473b4ae48 (4 commits)

https://pdfium.googlesource.com/pdfium.git/+log/08d96f1cadb1..473b4ae489e8

$ git log 08d96f1ca..473b4ae48 --date=short --no-merges --format='%ad %ae %s'
2018-05-15 thestig Lower the limit of image dimensions for fax codecs.
2018-05-15 thestig Read data in bigger chunks in fax codec code.
2018-05-15 thestig Clean up CBC_ASCIIEncoder.
2018-05-15 thestig Return earlier in CPDF_TextPage::ProcessInsertObject() when possible.

Created with:
  roll-dep src/third_party/pdfium
BUG= chromium:834633 , chromium:834633 


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I67c2cecc2867cf1ea9506e502702c67a3b1f5843
Reviewed-on: https://chromium-review.googlesource.com/1058927
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558633}
[modify] https://crrev.com/9696714ad13594ba58ec7842c2df39bd0f622017/DEPS

Project Member

Comment 10 by ClusterFuzz, May 16 2018

ClusterFuzz has detected this issue as fixed in range 558632:558634.

Detailed report: https://clusterfuzz.com/testcase?key=6580562035474432

Fuzzer: libFuzzer_pdf_codec_fax_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Timeout (exceeds 25 secs)
Crash Address: 
Crash State:
  pdf_codec_fax_fuzzer
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=453381:453413
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=558632:558634

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6580562035474432

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 11 by ClusterFuzz, May 16 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6580562035474432 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment