New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 834624 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

DCHECK failure in !trap_handler::IsThreadInWasm() in wasm-interpreter.cc

Project Member Reported by ClusterFuzz, Apr 19 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4972243399213056

Fuzzer: ochang_js_fuzzer
Job Type: linux_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  !trap_handler::IsThreadInWasm() in wasm-interpreter.cc
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_d8_dbg&range=52626:52627

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4972243399213056

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Apr 19 2018

Labels: Test-Predator-Auto-Owner
Owner: eholk@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/581fd6679b8b6778509a531501b03bd7497f6653 ([wasm] enable --wasm-trap-handler by default).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 2 by sheriffbot@chromium.org, Apr 19 2018

Labels: Pri-1

Comment 3 by eholk@chromium.org, Apr 19 2018

Cc: clemensh@chromium.org
Clemens - CCing you here in case you want more context on https://crrev.com/c/1019570

Comment 4 by vakh@chromium.org, Apr 20 2018

Labels: M-68 Security_Impact-Head
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 21 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/9286358071cfd060db186c32034fa37104cb4b95

commit 9286358071cfd060db186c32034fa37104cb4b95
Author: Eric Holk <eholk@chromium.org>
Date: Mon Apr 30 17:13:19 2018

[wasm][interpreter] Clear thread in wasm flag on exceptional return

A stack overflow can be thrown by JSEntryStub, which means the
thread-in-wasm flag will not have the expected value. To accommodate
this, we now clear the flag during exceptional returns if it is set.

Bug:  chromium:834624 
Change-Id: I8359af79886ab98dfecc2fb39ca19118b7fa38eb
Reviewed-on: https://chromium-review.googlesource.com/1019570
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Eric Holk <eholk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52891}
[modify] https://crrev.com/9286358071cfd060db186c32034fa37104cb4b95/src/wasm/wasm-interpreter.cc
[add] https://crrev.com/9286358071cfd060db186c32034fa37104cb4b95/test/mjsunit/regress/wasm/regress-834624.js

Project Member

Comment 7 by ClusterFuzz, May 1 2018

ClusterFuzz has detected this issue as fixed in range 52890:52891.

Detailed report: https://clusterfuzz.com/testcase?key=4972243399213056

Fuzzer: ochang_js_fuzzer
Job Type: linux_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  !trap_handler::IsThreadInWasm() in wasm-interpreter.cc
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_d8_dbg&range=52626:52627
Fixed: https://clusterfuzz.com/revisions?job=linux_d8_dbg&range=52890:52891

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4972243399213056

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, May 1 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4972243399213056 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 9 by sheriffbot@chromium.org, May 1 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable
Project Member

Comment 11 by sheriffbot@chromium.org, Aug 7

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment