Essential part of Extension Creation tutorial seems to be missing.
Reported by
scarabde...@gmail.com,
Apr 19 2018
|
||||||
Issue descriptionChrome Version : 65.0.3325.181 OS Version: 10.0 URLs (if applicable) : https://developer.chrome.com/extensions/getstarted Other browsers tested: Add OK or FAIL after other browsers where you have tested this issue: Safari: NA Firefox: NA IE/Edge: NA Following the tutorial, in the section headed "Layer Logic", the instructions direct the user to paste the presented code into the project. The result from the update gave the following error in the console: "popup.js:12 Uncaught ReferenceError: tabs is not defined" After a Google search, there was a suggestion of adding: "chrome.tabs.query({active: true, currentWindow: true}, function(tabs){..." to query the tabs API first. This fixed the issue for me. [https://stackoverflow.com/questions/23677082/error-in-sending-message-from-popup-html-to-content-script] I hope this is enough information for you to take action. If not, feel free to ask.
,
Apr 20 2018
,
Apr 20 2018
scarabdesign@ Thanks for the issue. Able to reproduce the issue on Windows 10, Mac OS 10.12.6 and Ubuntu 14.04 on the reported version 65.0.3325.181 and the latest Canary 68.0.3401.0. Can observe the same content in the link https://developer.chrome.com/extensions/getstarted from M-60 chrome builds. This is a Non-Regression issue. Hence marking this as Untriaged for further updates from Dev. Thanks..
,
Apr 20 2018
[Extensions Triage] Crystal can you take a look?
,
Apr 20 2018
Definitely something wrong, thanks for the issue. Submitted a fix.
,
Apr 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59445b2be75f9c8e0dc72f2f7196e7c492998d35 commit 59445b2be75f9c8e0dc72f2f7196e7c492998d35 Author: crystallambert@chromium.org <crystallambert@chromium.org> Date: Fri Apr 20 22:52:26 2018 [Extension Docs] Get Started Tutorial Code Issue Get started tutorial code snippet was causing an error. This update corrects this issue on tutorial page and completed file. Bug: 834614 Change-Id: Ia3d61ef1510383b3b278ac957deeab047142fcd9 Reviewed-on: https://chromium-review.googlesource.com/1022950 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Cr-Commit-Position: refs/heads/master@{#552505} [modify] https://crrev.com/59445b2be75f9c8e0dc72f2f7196e7c492998d35/chrome/common/extensions/docs/examples/tutorials/get_started_complete/popup.js [modify] https://crrev.com/59445b2be75f9c8e0dc72f2f7196e7c492998d35/chrome/common/extensions/docs/templates/articles/getstarted.html
,
Apr 23 2018
Tested this issue on Windows 10, Mac OS 10.13.3 and Ubuntu 14.04 on the reported version 65.0.3325.181 and the build with fix 68.0.3404.0. On navigating to the link https://developer.chrome.com/extensions/getstarted, can observe the same content in the build without fix and with fix. Attached are the webpages from the build with and without fix. crystallambert@ Request you to check and help us in verifying the fix on the latest M-68 68.0.3404.0 build. Thanks...
,
Apr 23 2018
@7: This was a bug relating to documentation which is hosted on a server; it is not expected to differ by Chrome version.
,
Apr 25 2018
P.S. I ran into another issue with the tutorial instructions and the downloadable snippets. In the section "Give Users Options", in the file optons.js, the code says "page.appendChild(button);", but "page" is undefined. I changed it to "document.body.appendChild(button);" and it worked. https://developer.chrome.com/extensions/getstarted Sean Hankins |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by vamshi.kommuri@chromium.org
, Apr 19 2018