New issue
Advanced search Search tips

Issue 834608 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Clicking an iron-icon in the settings left-drawer causes the settings page to re-attach

Project Member Reported by rjwright@chromium.org, Apr 19 2018

Issue description

Go to the settings page
Click the hamburger
Click and of the grey section icons
Note that the whole settings basic-page reloads

This doesn't happen if you click the text next to the icon, only if you click on the icon itself.
 
Cc: -calamity@chromium.org
Owner: calamity@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea5377bd2eaa7c2e7dcc1fa7d9fdda1f22539845

commit ea5377bd2eaa7c2e7dcc1fa7d9fdda1f22539845
Author: Christopher Lam <calamity@chromium.org>
Date: Fri Apr 20 08:45:55 2018

[MD Settings] Fix refresh on drawer icon click.

This CL fixes an issue where clicking an icon in the drawer would
fully refresh the page.

Bug:  834608 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7d89cf99ff55c214d8a6fd22267aca5e8823ddb1
Reviewed-on: https://chromium-review.googlesource.com/1021022
Reviewed-by: Renée Wright <rjwright@chromium.org>
Commit-Queue: Renée Wright <rjwright@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552286}
[modify] https://crrev.com/ea5377bd2eaa7c2e7dcc1fa7d9fdda1f22539845/chrome/browser/resources/settings/settings_menu/settings_menu.html

Status: Fixed (was: Started)

Sign in to add a comment