sizes failing on chromium.chrome/Google Chrome Win |
||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of patricialor@chromium.org sizes failing on chromium.chrome/Google Chrome Win Builders failed on: - Google Chrome Win: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win
,
Apr 19 2018
Seems that it started to fail here: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Win/29314
,
Apr 19 2018
I wonder if it could be related to changes made recently by rsesek@ https://chromium-review.googlesource.com/c/chromium/src/+/1017061 https://chromium-review.googlesource.com/c/chromium/tools/build/+/1017563
,
Apr 19 2018
,
Apr 19 2018
Issue 834786 has been merged into this issue.
,
Apr 19 2018
This is what the code looks like now:
```
def main_win(...):
...
result = 0
for f in files:
p = os.path.join(target_dir, f)
if os.path.isfile(p):
this_result = get_size(p) # Gets the file size of p in bytes
if result == 0:
result = this_result
results_collector.add_result(f, f, this_result, 'bytes')
return result
```
And the caller in main treats that as an exit code and returns it, so it's going to be non-zero.
,
Apr 19 2018
Thanks for catching that Reid! Manual-merge fail. https://chromium-review.googlesource.com/#/c/chromium/src/+/1019980
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70c56b8ff35427244ef484c2b176421a80d76da9 commit 70c56b8ff35427244ef484c2b176421a80d76da9 Author: Robert Sesek <rsesek@chromium.org> Date: Thu Apr 19 19:58:34 2018 Fix a bug in sizes.py on Windows where main_win() was returning non-zero. This was caused by an erroneous manual merge in 15bbc3bf959efe5264443bea08f99a77b44f7921. Bug: 783855 , 834604 Change-Id: I1f821b5c86d7c11478f4430f68bce58238c1d9bc Reviewed-on: https://chromium-review.googlesource.com/1019980 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#552132} [modify] https://crrev.com/70c56b8ff35427244ef484c2b176421a80d76da9/infra/scripts/legacy/scripts/slave/chromium/sizes.py
,
Apr 19 2018
https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Win/29352 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by patricia...@chromium.org
, Apr 19 2018