New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 834599 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 836131
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-buffer-overflow in angle::LoadLA8ToRGBA8

Project Member Reported by ClusterFuzz, Apr 19 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5252436193968128

Fuzzer: webDEViL_webgl
Job Type: windows_asan_chrome_with_gpu
Platform Id: windows

Crash Type: Heap-buffer-overflow READ 1
Crash Address: 0x12b043cb7600
Crash State:
  angle::LoadLA8ToRGBA8
  rx::Image11::loadData
  rx::TextureD3D::initializeContents
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5252436193968128

Issue manually filed by: aarya

See https://github.com/google/clusterfuzz-tools for more information.
 

Comment 1 by aarya@google.com, Apr 19 2018

Cc: zmo@chromium.org kbr@chromium.org
Components: Internals>GPU>ANGLE
Labels: Pri-1
Owner: geoffl...@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by aarya@google.com, Apr 19 2018

This is coming from our new shiny gce bots with nvidia gpus. (tesla-p100)

Comment 3 by aarya@google.com, Apr 19 2018

Owner: cwallez@chromium.org
TextureD3D_2D::CopyImage clear using initializeContents by cwallez@chromium.org
Suspected changelist touched the crashing line in TextureD3D.cpp
Suspected changelist touched file(s) in the directories src/libANGLE, src/libANGLE/renderer/d3d, which appear in the stack trace.
Suspected changelist touched file TextureD3D.cpp, which appears in the stack trace.

Comment 4 by vakh@chromium.org, Apr 21 2018

Labels: Security_Impact-Head

Comment 5 by vakh@chromium.org, Apr 21 2018

Labels: M-68
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 21 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by ClusterFuzz, Apr 24 2018

ClusterFuzz has detected this issue as fixed in range 552146:552148.

Detailed report: https://clusterfuzz.com/testcase?key=5252436193968128

Fuzzer: webDEViL_webgl
Job Type: windows_asan_chrome_with_gpu
Platform Id: windows

Crash Type: Heap-buffer-overflow READ 1
Crash Address: 0x1176094a1280
Crash State:
  angle::LoadLA8ToRGBA8
  rx::Image11::loadData
  rx::TextureD3D::initializeContents
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_with_gpu&range=550440:550450
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_with_gpu&range=552146:552148

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5252436193968128

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Apr 24 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5252436193968128 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 9 by sheriffbot@chromium.org, Apr 24 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 10 by ClusterFuzz, Apr 24 2018

ClusterFuzz has detected this issue as fixed in range 552581:552589.

Detailed report: https://clusterfuzz.com/testcase?key=5252436193968128

Fuzzer: webDEViL_webgl
Job Type: windows_asan_chrome_with_gpu
Platform Id: windows

Crash Type: Heap-buffer-overflow READ 1
Crash Address: 0x1176094a1280
Crash State:
  angle::LoadLA8ToRGBA8
  rx::Image11::loadData
  rx::TextureD3D::initializeContents
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_with_gpu&range=550440:550450
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_with_gpu&range=552581:552589

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5252436193968128

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Cc: geoffl...@chromium.org
+Geoff, this is fixed by your CL right?
Very likely, yes.
Mergedinto: 836131
Status: Duplicate (was: Verified)
Project Member

Comment 14 by sheriffbot@chromium.org, May 3 2018

Labels: -reward-topanel reward-ineligible
Project Member

Comment 15 by sheriffbot@chromium.org, Aug 1

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment