New issue
Advanced search Search tips

Issue 834596 link

Starred by 1 user
Status: Fixed
Owner:
ricea@chromium.org
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

modules/websockets/*web_socket* should be *websocket*

Project Member Reported by ricea@chromium.org, Apr 19 2018 
The great Blink rename changed DOMWebSocket.h to dom_web_socket.h, and similarly for the other files. WebSocket is one word that happens to have a capital letter in the middle. So the file should be called dom_websocket.h.

Comment 1 by ricea@chromium.org, Apr 23 2018 

I should have changed build/scripts/blinkbuild/name_style_converter.py before the great rename. It would have saved a lot of trouble if I'd known this.
Project Member

Comment 2 by bugdroid1@chromium.org, May 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d096e6eea49e037293494942d02669b774a5d25

commit 3d096e6eea49e037293494942d02669b774a5d25
Author: Adam Rice <ricea@chromium.org>
Date: Tue May 01 14:35:56 2018

Rename web_socket to websocket

The great Blink rename left Blink's WebSocket C++ implementation files
with "web_socket" in the name. Since WebSocket is one word, it should be
"websocket". Rename the files.

In order to keep it trivial, this CL only changes files inside
modules/websocket. Header files elsewhere have more dependencies and
will need to be cleaned up separately.

Also modify blinkbuild/name_style_converter.py to recognise "WebSocket"
as one word. This is needed to satisfy the IDL compiler.

Also fix some lint and formatting errors to keep the presubmit happy.

BUG= 834596 

Change-Id: I315fa0f8b96a98be4477cde31e42665eed255fb8
Reviewed-on: https://chromium-review.googlesource.com/1023679
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555036}
[modify] https://crrev.com/3d096e6eea49e037293494942d02669b774a5d25/third_party/blink/renderer/build/scripts/blinkbuild/name_style_converter.py
[modify] https://crrev.com/3d096e6eea49e037293494942d02669b774a5d25/third_party/blink/renderer/modules/BUILD.gn
[modify] https://crrev.com/3d096e6eea49e037293494942d02669b774a5d25/third_party/blink/renderer/modules/modules_idl_files.gni
[modify] https://crrev.com/3d096e6eea49e037293494942d02669b774a5d25/third_party/blink/renderer/modules/websockets/BUILD.gn
[rename] https://crrev.com/3d096e6eea49e037293494942d02669b774a5d25/third_party/blink/renderer/modules/websockets/dom_websocket.cc
[rename] https://crrev.com/3d096e6eea49e037293494942d02669b774a5d25/third_party/blink/renderer/modules/websockets/dom_websocket.h
[rename] https://crrev.com/3d096e6eea49e037293494942d02669b774a5d25/third_party/blink/renderer/modules/websockets/dom_websocket_test.cc
[rename] https://crrev.com/3d096e6eea49e037293494942d02669b774a5d25/third_party/blink/renderer/modules/websockets/inspector_websocket_events.cc
[rename] https://crrev.com/3d096e6eea49e037293494942d02669b774a5d25/third_party/blink/renderer/modules/websockets/inspector_websocket_events.h
[modify] https://crrev.com/3d096e6eea49e037293494942d02669b774a5d25/third_party/blink/renderer/modules/websockets/web_pepper_socket_channel_client_proxy.h
[modify] https://crrev.com/3d096e6eea49e037293494942d02669b774a5d25/third_party/blink/renderer/modules/websockets/web_pepper_socket_impl.cc
[modify] https://crrev.com/3d096e6eea49e037293494942d02669b774a5d25/third_party/blink/renderer/modules/websockets/web_pepper_socket_impl.h
[rename] https://crrev.com/3d096e6eea49e037293494942d02669b774a5d25/third_party/blink/renderer/modules/websockets/websocket.idl
[rename] https://crrev.com/3d096e6eea49e037293494942d02669b774a5d25/third_party/blink/renderer/modules/websockets/websocket_channel.cc
[rename] https://crrev.com/3d096e6eea49e037293494942d02669b774a5d25/third_party/blink/renderer/modules/websockets/websocket_channel.h
[rename] https://crrev.com/3d096e6eea49e037293494942d02669b774a5d25/third_party/blink/renderer/modules/websockets/websocket_channel_client.h
[rename] https://crrev.com/3d096e6eea49e037293494942d02669b774a5d25/third_party/blink/renderer/modules/websockets/websocket_channel_impl.cc
[rename] https://crrev.com/3d096e6eea49e037293494942d02669b774a5d25/third_party/blink/renderer/modules/websockets/websocket_channel_impl.h
[rename] https://crrev.com/3d096e6eea49e037293494942d02669b774a5d25/third_party/blink/renderer/modules/websockets/websocket_channel_impl_test.cc
[rename] https://crrev.com/3d096e6eea49e037293494942d02669b774a5d25/third_party/blink/renderer/modules/websockets/websocket_handle.h
[rename] https://crrev.com/3d096e6eea49e037293494942d02669b774a5d25/third_party/blink/renderer/modules/websockets/websocket_handle_client.h
[rename] https://crrev.com/3d096e6eea49e037293494942d02669b774a5d25/third_party/blink/renderer/modules/websockets/websocket_handle_impl.cc
[rename] https://crrev.com/3d096e6eea49e037293494942d02669b774a5d25/third_party/blink/renderer/modules/websockets/websocket_handle_impl.h
[rename] https://crrev.com/3d096e6eea49e037293494942d02669b774a5d25/third_party/blink/renderer/modules/websockets/worker_websocket_channel.cc
[rename] https://crrev.com/3d096e6eea49e037293494942d02669b774a5d25/third_party/blink/renderer/modules/websockets/worker_websocket_channel.h
Project Member

Comment 3 by bugdroid1@chromium.org, May 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/960f44a9cf834aa27d47245d83a67c2cccb0d277

commit 960f44a9cf834aa27d47245d83a67c2cccb0d277
Author: Adam Rice <ricea@chromium.org>
Date: Mon May 14 11:32:05 2018

Rename websocket_handshake_throttle.h

The Great Blink Move resulted in a header file named
"web_socket_handshake_throttle.h". Since "WebSocket" is one word, it should be
"websocket_handshake_throttle.h". Rename it.

BUG= 834596 
TBR=boliu@chromium.org
TBR=kinuko@chromium.org
TBR=jialiul@chromium.org
TBR=thestig@chromium.org

Change-Id: Ifc154d6942b691b70b4d5e7366bebc1bfa3c4218
Reviewed-on: https://chromium-review.googlesource.com/1056892
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558260}
[modify] https://crrev.com/960f44a9cf834aa27d47245d83a67c2cccb0d277/android_webview/renderer/aw_websocket_handshake_throttle_provider.cc
[modify] https://crrev.com/960f44a9cf834aa27d47245d83a67c2cccb0d277/chrome/renderer/websocket_handshake_throttle_provider_impl.cc
[modify] https://crrev.com/960f44a9cf834aa27d47245d83a67c2cccb0d277/components/safe_browsing/renderer/websocket_sb_handshake_throttle.h
[modify] https://crrev.com/960f44a9cf834aa27d47245d83a67c2cccb0d277/content/public/renderer/content_renderer_client.cc
[modify] https://crrev.com/960f44a9cf834aa27d47245d83a67c2cccb0d277/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/960f44a9cf834aa27d47245d83a67c2cccb0d277/content/shell/renderer/layout_test/test_websocket_handshake_throttle_provider.h
[modify] https://crrev.com/960f44a9cf834aa27d47245d83a67c2cccb0d277/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/960f44a9cf834aa27d47245d83a67c2cccb0d277/third_party/blink/public/platform/web_worker_fetch_context.h
[rename] https://crrev.com/960f44a9cf834aa27d47245d83a67c2cccb0d277/third_party/blink/public/platform/websocket_handshake_throttle.h
[modify] https://crrev.com/960f44a9cf834aa27d47245d83a67c2cccb0d277/third_party/blink/renderer/core/loader/base_fetch_context_test.cc
[modify] https://crrev.com/960f44a9cf834aa27d47245d83a67c2cccb0d277/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/960f44a9cf834aa27d47245d83a67c2cccb0d277/third_party/blink/renderer/modules/websockets/websocket_channel_impl.cc
[modify] https://crrev.com/960f44a9cf834aa27d47245d83a67c2cccb0d277/third_party/blink/renderer/modules/websockets/websocket_channel_impl_test.cc
[modify] https://crrev.com/960f44a9cf834aa27d47245d83a67c2cccb0d277/third_party/blink/renderer/platform/exported/platform.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3102f62b8ea96f84a8fd5185d1e0e2506525127

commit b3102f62b8ea96f84a8fd5185d1e0e2506525127
Author: Adam Rice <ricea@chromium.org>
Date: Thu Jun 14 09:23:55 2018

Rename web_socket_handshake_*.{h,cc}

The Blink rename changed the WebSocket handshake files from WebSocketHandshake*
to web_socket_handshake*. Since WebSocket is one word, these should properly be
websocket_handshake*. Fix them.

BUG= 834596 

Change-Id: I2009a679c948ea460713890ed548e42d797b290c
Reviewed-on: https://chromium-review.googlesource.com/1098743
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567204}
[modify] https://crrev.com/b3102f62b8ea96f84a8fd5185d1e0e2506525127/third_party/blink/renderer/core/inspector/inspector_network_agent.cc
[modify] https://crrev.com/b3102f62b8ea96f84a8fd5185d1e0e2506525127/third_party/blink/renderer/modules/websockets/websocket_channel_impl.cc
[modify] https://crrev.com/b3102f62b8ea96f84a8fd5185d1e0e2506525127/third_party/blink/renderer/modules/websockets/websocket_handle_impl.cc
[modify] https://crrev.com/b3102f62b8ea96f84a8fd5185d1e0e2506525127/third_party/blink/renderer/platform/network/BUILD.gn
[rename] https://crrev.com/b3102f62b8ea96f84a8fd5185d1e0e2506525127/third_party/blink/renderer/platform/network/websocket_handshake_request.cc
[rename] https://crrev.com/b3102f62b8ea96f84a8fd5185d1e0e2506525127/third_party/blink/renderer/platform/network/websocket_handshake_request.h
[rename] https://crrev.com/b3102f62b8ea96f84a8fd5185d1e0e2506525127/third_party/blink/renderer/platform/network/websocket_handshake_response.cc
[rename] https://crrev.com/b3102f62b8ea96f84a8fd5185d1e0e2506525127/third_party/blink/renderer/platform/network/websocket_handshake_response.h

Comment 5 by ricea@chromium.org, Jun 14 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment