crosvm dies after suspend resume |
||||||||
Issue descriptionTo reproduce: 1) Start a crosvm instance 2) Suspend (i.e. by closing the lid) 3) Resume (i.e. open the lid) 5) Observe that crosvm has exited with error messages similar to "failed to poll: Error(4)" This errno (4) indicates EINTR. This is probably related to the new PollContext::wait method, which does not retry epoll_wait when it returns EINTR, unlike its predecessor.
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/crosvm/+/d14c41a81fa71fba2e868fbc86c1b28c05186001 commit d14c41a81fa71fba2e868fbc86c1b28c05186001 Author: Zach Reizner <zachr@google.com> Date: Thu Apr 19 08:13:09 2018 sys_util: handle EINTR return from epoll_wait The PollContext::wait returns Error on EINTR, which often happens during suspend/resume cycles. Because this Error is transient, this should be handled internally with a retry until a fatal error is encountered. BUG= chromium:834558 TEST=run crosvm, suspend, resume, observe crosvm still running Change-Id: I75469e261ddf28f025a3b3b93612538ccf1230b9 Reviewed-on: https://chromium-review.googlesource.com/1018527 Commit-Ready: Zach Reizner <zachr@chromium.org> Tested-by: Zach Reizner <zachr@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org> [modify] https://crrev.com/d14c41a81fa71fba2e868fbc86c1b28c05186001/sys_util/src/poll.rs
,
Apr 19 2018
Updated subject with "eve:" to call out the impacted board
,
Apr 19 2018
To be clear, this issue affects all boards with crosvm.
,
Apr 19 2018
Ah, good call, I'll update the subject to remove 'eve'. It was helpful for the release but misleading on the bug.
,
Apr 20 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 23 2018
Please update after this is merged so we can capture in the next RC. Thanks
,
Apr 23 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/crosvm/+/e52f622f8d8df5e7328712428f041053ab0a4e13 commit e52f622f8d8df5e7328712428f041053ab0a4e13 Author: Zach Reizner <zachr@google.com> Date: Mon Apr 23 23:11:22 2018 sys_util: handle EINTR return from epoll_wait The PollContext::wait returns Error on EINTR, which often happens during suspend/resume cycles. Because this Error is transient, this should be handled internally with a retry until a fatal error is encountered. BUG= chromium:834558 TEST=run crosvm, suspend, resume, observe crosvm still running Change-Id: I75469e261ddf28f025a3b3b93612538ccf1230b9 Reviewed-on: https://chromium-review.googlesource.com/1018527 Commit-Ready: Zach Reizner <zachr@chromium.org> Tested-by: Zach Reizner <zachr@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org> (cherry picked from commit d14c41a81fa71fba2e868fbc86c1b28c05186001) Reviewed-on: https://chromium-review.googlesource.com/1024647 Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> Tested-by: Chirantan Ekbote <chirantan@chromium.org> Commit-Queue: Chirantan Ekbote <chirantan@chromium.org> [modify] https://crrev.com/e52f622f8d8df5e7328712428f041053ab0a4e13/sys_util/src/poll.rs
,
Apr 23 2018
,
Apr 26 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 5 2018
Hi, the Merge-Approved-67 label was never removed after this blocking merge request. Assume the merge was made and we can remove it?
,
Jun 6 2018
I believe so. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bhthompson@google.com
, Apr 19 2018