New issue
Advanced search Search tips

Issue 834524 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 10
Cc:
Components:
EstimatedDays: 3
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 834522



Sign in to add a comment

Add multi-login window teleportation to window frame in Refresh

Project Member Reported by bettes@chromium.org, Apr 19 2018

Issue description

Attached is current spec. Expected design tbd
 
Chrome Tablet - Main spec.png
56.5 KB View Download
Will need CrOS folks to weigh in here.
Status: Available (was: Untriaged)

Comment 3 by pbos@chromium.org, Apr 27 2018

Blocking: 834522
Cc: markchang@chromium.org
Labels: -Pri-2 Pri-1
Owner: bettes@chromium.org
Owner: markchang@chromium.org
Status: Assigned (was: Available)

Comment 6 by pbos@chromium.org, Jun 15 2018

Cc: bettes@chromium.org
EstimatedDays: 3
Owner: pbos@chromium.org
Summary: Add multi-login window teleportation to window frame in Refresh (was: [Touch] Update multi-login window teleportation)
From email thread: bettes@ doesn't have strong feelings about "badge in window corner" (before the NTB) vs. "badge before caption buttons".

I suspect implementing the latter might be easier, as it's basically where the avatar button used to be, and in particular, if we do the former, we'll need to remember to undo the NTB Fitts' Law extensions (which are not yet implemented, see  bug 848429 ) in the teleported window case.

Comment 8 by pbos@chromium.org, Jun 18 2018

Looks like LHS is easier as that's the existing placement and code from pre-Refresh Touchable CrOS.
Be careful about padding around the button in that case.
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7f85be53fac90df905e37bcf09f92a3d5c1628b

commit d7f85be53fac90df905e37bcf09f92a3d5c1628b
Author: Peter Boström <pbos@chromium.org>
Date: Tue Jun 19 00:13:43 2018

Badge teleported windows in Refresh on ChromeOS

Adds back parts of ShouldShowProfileIndicatorIcon on ChromeOS under
Refresh. This indicator should now show under Refresh but only for
teleported browser windows.

Bug:  chromium:834524 
Change-Id: I40e4233f2ffdf6df3f07ee6b0cc41e9d5b5f6a9a
Reviewed-on: https://chromium-review.googlesource.com/1105278
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568247}
[modify] https://crrev.com/d7f85be53fac90df905e37bcf09f92a3d5c1628b/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc

Comment 11 by pbos@chromium.org, Jun 19 2018

Status: Fixed (was: Assigned)
Cc: omrilio@chromium.org
Status: Assigned (was: Fixed)
Seems that the coloring of the avatar makes it invisible. Same for guest badge. The space is being made, but nothing seems to show up.
Cc: pbos@chromium.org
Owner: markchang@chromium.org
Can you try verifying again? Dev might've been just too old when we checked last and it really looks fixed on trunk.
Owner: pbos@chromium.org
Status: Verified (was: Assigned)
We must've tested on a too-old CrOS Dev version.
Screenshot 2018-07-10 at 13.12.44.png
193 KB View Download

Sign in to add a comment