Add multi-login window teleportation to window frame in Refresh |
|||||||||||
Issue descriptionAttached is current spec. Expected design tbd
,
Apr 26 2018
,
Apr 27 2018
,
May 31 2018
,
May 31 2018
,
Jun 15 2018
,
Jun 18 2018
From email thread: bettes@ doesn't have strong feelings about "badge in window corner" (before the NTB) vs. "badge before caption buttons". I suspect implementing the latter might be easier, as it's basically where the avatar button used to be, and in particular, if we do the former, we'll need to remember to undo the NTB Fitts' Law extensions (which are not yet implemented, see bug 848429 ) in the teleported window case.
,
Jun 18 2018
Looks like LHS is easier as that's the existing placement and code from pre-Refresh Touchable CrOS.
,
Jun 18 2018
Be careful about padding around the button in that case.
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7f85be53fac90df905e37bcf09f92a3d5c1628b commit d7f85be53fac90df905e37bcf09f92a3d5c1628b Author: Peter Boström <pbos@chromium.org> Date: Tue Jun 19 00:13:43 2018 Badge teleported windows in Refresh on ChromeOS Adds back parts of ShouldShowProfileIndicatorIcon on ChromeOS under Refresh. This indicator should now show under Refresh but only for teleported browser windows. Bug: chromium:834524 Change-Id: I40e4233f2ffdf6df3f07ee6b0cc41e9d5b5f6a9a Reviewed-on: https://chromium-review.googlesource.com/1105278 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#568247} [modify] https://crrev.com/d7f85be53fac90df905e37bcf09f92a3d5c1628b/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
,
Jun 19 2018
,
Jun 19 2018
,
Jun 28 2018
Seems that the coloring of the avatar makes it invisible. Same for guest badge. The space is being made, but nothing seems to show up.
,
Jul 9
Can you try verifying again? Dev might've been just too old when we checked last and it really looks fixed on trunk.
,
Jul 10
We must've tested on a too-old CrOS Dev version. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by kylixrd@chromium.org
, Apr 26 2018