Add guest and incognito badging to toolbar for ChromeOS Refresh/TouchableRefresh |
|||||||||||
Issue descriptionMoving incognito badge from the new tab button to the profile slot in the toolbar
,
Apr 26 2018
There's (currently, incl. refresh) no slot for profiles in the browser in ChromeOS as the OS handles profile switching. Do you want this slot to be added to ChromeOS? If so is it only for incognito or at all times?
,
Apr 26 2018
ah yes, I saw a mock putting it back in the tabstrip @Alan. Would that be the path forward for CrOS ?
,
Apr 26 2018
This needs more thought put into it and sort of depends on the status of crbug.com/834524 . If 834524 is a GO, then maybe a slot is added to ChromeOS for normal and incognito modes. If 834524 is NOT a go, then maybe a slot is added for incognito only.
,
Apr 27 2018
That bug looks unassigned and doesn't have proper owners. Do you know who to assign it to? I'll mark this
,
Apr 27 2018
.. mark this as blocked for now.
,
May 29 2018
,
May 31 2018
,
Jun 1 2018
Does this mean that we can show the trusted-area-separator when displaying extensions on ChromeOS, even if the trusted area only has the 3dot menu in some cases? I think this is the right thing to do. Guest: Probably not? Signed in: Only for teleported windows? *This part might be tricky*, I don't know yet. Incognito: Always
,
Jun 1 2018
Here's a gif of the touchable area with only the 3dot menu present on touchable refresh. I think this is fine / even better than status quo.
,
Jun 14 2018
,
Jun 14 2018
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/799b030e92cae27c506b3b13bd116dc83f153069 commit 799b030e92cae27c506b3b13bd116dc83f153069 Author: Peter Boström <pbos@chromium.org> Date: Fri Jun 15 19:23:32 2018 Show incognito/guest badging in toolbar on CrOS Exposes the avatar toolbar button for Incognito and Guest profiles on ChromeOS. While doing this the button is disabled so that it only acts only as a badge and not a way to invoke a profile switcher. Without this change under Refresh modes there were no visible Incognito or Guest indicator icons in the browser window. Bug: chromium:834522 Change-Id: If1cc5bea8da5a5e87d506a48ae8c668cc75c86e2 Reviewed-on: https://chromium-review.googlesource.com/1101546 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#567762} [modify] https://crrev.com/799b030e92cae27c506b3b13bd116dc83f153069/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/799b030e92cae27c506b3b13bd116dc83f153069/chrome/browser/ui/views/profiles/avatar_toolbar_button.cc [modify] https://crrev.com/799b030e92cae27c506b3b13bd116dc83f153069/chrome/browser/ui/views/profiles/avatar_toolbar_button.h [modify] https://crrev.com/799b030e92cae27c506b3b13bd116dc83f153069/chrome/browser/ui/views/toolbar/toolbar_view.cc
,
Jun 15 2018
,
Jun 28 2018
Seems that the coloring of the avatar makes it invisible. Same for guest badge. The space is being made, but nothing seems to show up.
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47da420f16f739a51c2513c7825d0d2305c84856 commit 47da420f16f739a51c2513c7825d0d2305c84856 Author: Peter Boström <pbos@chromium.org> Date: Fri Jun 29 20:25:31 2018 Set the AvatarToolbarButton icon on CrOS This code was previously excluded as AvatarToolbarButton wasn't compiled on CrOS. When the code for badging Guest and Incognito on CrOS was put back an UpdateIcon() call was missed. Bug: chromium:834522 Change-Id: Iee5989cea8fcdbdea5fc3e03717d3476b68d8d11 Reviewed-on: https://chromium-review.googlesource.com/1120954 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#571612} [modify] https://crrev.com/47da420f16f739a51c2513c7825d0d2305c84856/chrome/browser/ui/views/toolbar/toolbar_view.cc
,
Jun 29 2018
Verified on CrOS on Linux, so this should be alright now. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by kylixrd@chromium.org
, Apr 26 2018Status: Available (was: Untriaged)