Printer setup for some autoconf printers due to blocked syscall |
|||||||||||||||
Issue descriptionChrome Version: 68.0.3397.0 canary Chrome OS Version: 10594.0.0 Chrome OS Platform: kefka Network info: Wireless WPA2 Steps To Reproduce: (1) chrome://settings/cupsPrinters (2) ADD PRINTER (3) Choose a networked printer (e.g. Epson XP-640) from "Add a nearby printer" (4) Click ADD Expected Result: Dialog asks for a PPD Actual Result: Dialog goes away. No error message displayed. Printer is not setup. How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Always What is the impact to the user, and is there a workaround? If so, what is it? Cannot setup printers Please provide any additional information below. Attach a screen shot or log if possible. Feedback report: go/odqby For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Apr 19 2018
Thanks Sean for reporting this issue. Seems not M68 only - Prasanthi was able to reproduce it on M67(dev candidate today). Having no test caught this bug, I have a word from cychiang, the chameleon build with printer driver is ready, and I'll start testing it locally. Soon to get e2e test out running. It should be able to catch such bugs.
,
Apr 19 2018
Tested on Kip with build version 10575.4.0/67.0.3396.8 and was able to reproduce the issue. Logs attached here: https://pantheon.corp.google.com/storage/browser/chromiumos-test-logs/bugfiles/cr/834521
,
Apr 19 2018
Just tested on my caroline device with version 67.0.3396.0, the PPD dialog seems to pop up correctly.
,
Apr 19 2018
Current dev channel, 67.0.3383.0 seems to be working.
,
Apr 20 2018
pgangishetty@ is reporting this is ONLY Epson printer issue. Also, if the printer is found in Print dialog > Print Destinations, the print job is successful. pgangishetty@, can you check the browser JS console for any errors while setting up Epson printer from "Add a nearby printer"?
,
Apr 20 2018
,
Apr 20 2018
Tested on Nautilus with build version 10575.8.0/67.0.3396.12 and see the observations below: 1. Tried to add printers using 'Add Nearby Printers' option (HP & EPSON) 2. Able to add HP printer successfully - https://screenshot.googleplex.com/Xq3JDQqij1p 3. When i tried to add EPSON printer as soon as I click on 'ADD' button i see couple of console errors - https://screenshot.googleplex.com/nJwrBKjYX6m
,
Apr 20 2018
I can reproduce with non-epson printers. The issue is for printers that attempt automatic configuration then fail. If a printer is unreachable during setup, it is okay.
,
Apr 20 2018
So we used to handle this as a valid scenario before, and now a regression exposed the failing auto-cofiguration printers? Is there any way this can be replicated in platform_AddPrinter test as separate scenario?
,
Apr 20 2018
The failure is in Chrome, so it's not tested by platform_AddPrinter. We need a browser test for this or something telemetry based. It's a UI bug. This is a regression.
,
Apr 20 2018
lpadmin appears to be crashing. So we seem to have two independent bugs.
,
Apr 20 2018
Does the crash in lpadmin have anything to do with the patch to CUPS that I made? https://crrev.com/c/817524
,
Apr 21 2018
I don't think so. But I'm not sure yet. There's a seccomp policy violation coming from gnutls. It could be a number of things.
,
Apr 21 2018
lpadmin is missing getrandom. I'll add it to the syscall filter.
,
Apr 21 2018
So, this is occurring for ipps queries only. However, it can occur with an Epson XP-640 because that printer requires a TLS upgrade.
,
Apr 21 2018
The first reported instance of this crash is in 10509.0.0 which corresponds to M67.
,
Apr 23 2018
Can we create a seperate bug for the crash and tag that as a blocker? Best to treat these separately imho. Assume the crash is the blocker here, not the new PDD feature?
,
Apr 23 2018
The root cause is the crash so that is this bug now. The UI fix has been filed separately as https://bugs.chromium.org/p/chromium/issues/detail?id=835476. Strictly speaking, it's not blocking since fixing the lpadmin failure will make the problem go away.
,
Apr 23 2018
I'm going to remove the RBB per #19. Thanks.
,
Apr 23 2018
This bug is the root cause and should be blocking. The referred to bug is non-blocking.
,
Apr 23 2018
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/772de2705718ab588211972d9d71f832875db26e commit 772de2705718ab588211972d9d71f832875db26e Author: Sean Kau <skau@chromium.org> Date: Tue Apr 24 07:30:06 2018 net-print/cups: Add getrandom to lpadmin filter lpadmin needs getrandom when establishing TLS connections with a printer using IPPS or requesting a TLS upgrade over IPP. The syscall originates in the GnuTLS library. Add clock_gettime to the *-arm filter which has librt. *-amd64 uses gettimeofday. BUG= chromium:834521 TEST=Verified setup of IPPS printers on elm and cave Change-Id: Iceea9642f6b50e964045ba1393c55d5a65176078 Reviewed-on: https://chromium-review.googlesource.com/1023274 Commit-Ready: Sean Kau <skau@chromium.org> Tested-by: Sean Kau <skau@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [modify] https://crrev.com/772de2705718ab588211972d9d71f832875db26e/net-print/cups/files/lpadmin-seccomp-amd64.policy [modify] https://crrev.com/772de2705718ab588211972d9d71f832875db26e/net-print/cups/files/lpadmin-seccomp-x86.policy [modify] https://crrev.com/772de2705718ab588211972d9d71f832875db26e/net-print/cups/files/lpadmin-seccomp-arm.policy [rename] https://crrev.com/772de2705718ab588211972d9d71f832875db26e/net-print/cups/cups-2.1.4-r46.ebuild
,
Apr 24 2018
Thanks for the clarification on #21. Assume #23 is the fix and we can test on Dev or ToT and then shoot off a merge request? Thx
,
Apr 24 2018
That is correct. #23 is the patch and I'll verify in Canary that it is fixed.
,
Apr 24 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-67; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-67 label, otherwise remove Merge-TBD label. Thanks.
,
Apr 24 2018
Landed in 10613.0.0
,
Apr 25 2018
pgangishetty@ reported print settings WAI with ToT build 10614.0.0/68.0.3405.0. Epson(and the rest printers) added from ADD NEARBY PRINTERS successfully. No JS errors present.
,
Apr 25 2018
,
Apr 26 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/4d376f97fa82f808e13746bb597de0f3f73c79b5 commit 4d376f97fa82f808e13746bb597de0f3f73c79b5 Author: Sean Kau <skau@chromium.org> Date: Thu Apr 26 17:55:39 2018 net-print/cups: Add getrandom to lpadmin filter lpadmin needs getrandom when establishing TLS connections with a printer using IPPS or requesting a TLS upgrade over IPP. The syscall originates in the GnuTLS library. Add clock_gettime to the *-arm filter which has librt. *-amd64 uses gettimeofday. BUG= chromium:834521 TEST=Verified setup of IPPS printers on elm and cave Change-Id: Iceea9642f6b50e964045ba1393c55d5a65176078 Reviewed-on: https://chromium-review.googlesource.com/1023274 Commit-Ready: Sean Kau <skau@chromium.org> Tested-by: Sean Kau <skau@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> (cherry picked from commit 772de2705718ab588211972d9d71f832875db26e) Reviewed-on: https://chromium-review.googlesource.com/1030232 Reviewed-by: Sean Kau <skau@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> [modify] https://crrev.com/4d376f97fa82f808e13746bb597de0f3f73c79b5/net-print/cups/files/lpadmin-seccomp-amd64.policy [modify] https://crrev.com/4d376f97fa82f808e13746bb597de0f3f73c79b5/net-print/cups/files/lpadmin-seccomp-x86.policy [modify] https://crrev.com/4d376f97fa82f808e13746bb597de0f3f73c79b5/net-print/cups/files/lpadmin-seccomp-arm.policy [rename] https://crrev.com/4d376f97fa82f808e13746bb597de0f3f73c79b5/net-print/cups/cups-2.1.4-r46.ebuild
,
Apr 26 2018
,
May 2 2018
Verified on Auron-Paine, Daisy & Bruce (clamshell & tablet mode) on M67 build 10575.22.0/67.0.3396.26 (for Epson & Officejet printers). |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by skau@chromium.org
, Apr 19 2018