[Touch] Update new tab button |
||||
Issue descriptionCurrent ntb: right handed + icon with border Expected ntb: left handed + icon, no border Current ntb (incognito): right handed + icon with border, with incognito icon Expected ntb (incognito): left handed + icon, no border, no incognito icon ---- From go/chrome-ux-gm2: https://docs.google.com/presentation/d/1EO7TOpIMJ7QHjaTVw9St-q6naKwtXX2TwzMirG5EsKY/edit#slide=id.g36e7d8d795_33_186 Tearsheet: go/chrome-ux-gm2-core
,
May 29 2018
,
May 31 2018
,
May 31 2018
The positioning is done. However, new_tab_button.cc needs some thought put into what parts should continue to use IsTouchOptimizedUiEnabled(), since when I wrote the refresh code in there I assumed that implied non-refresh. So the painting in touchable refresh is probably goofy.
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5a6dce0773b8eaaa29b345c3dcf728f6e8284aa commit b5a6dce0773b8eaaa29b345c3dcf728f6e8284aa Author: Peter Boström <pbos@chromium.org> Date: Tue Jun 05 21:43:10 2018 Unify Touchable Refresh NTB with Refresh * Removes the incognito badging from the new-tab button. * Uses the same inkdrop base color as Refresh does. * Adds a couple of DCHECKs to document which paths are dead in Refresh for easier cleanup when pre-Refresh modes go away. This change was essentially done by auditing IsTouchOptimizedUiEnabled() calls in the new-tab button and making sure that the existing Refresh code takes precedence. Bug: chromium:834520 Change-Id: I28e244472780f65f11d5f3309c567b21401d20ad Reviewed-on: https://chromium-review.googlesource.com/1082436 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#564675} [modify] https://crrev.com/b5a6dce0773b8eaaa29b345c3dcf728f6e8284aa/chrome/browser/ui/views/tabs/new_tab_button.cc
,
Jun 5 2018
Done afaict (this now uses all of the Refresh path under Touchable Refresh). |
||||
►
Sign in to add a comment |
||||
Comment 1 by kylixrd@chromium.org
, Apr 26 2018Owner: pkasting@chromium.org
Status: Available (was: Untriaged)