Current touchable shape/ripple: circle Expected touchable shape/ripple: 8dp square ---- From go/chrome-ux-gm2: https://docs.google.com/presentation/d/1EO7TOpIMJ7QHjaTVw9St-q6naKwtXX2TwzMirG5EsKY/edit#slide=id.g36e7d8d795_33_218 Tearsheet: go/chrome-ux-gm2-core
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbcce752dbe0afe0913000e7726267564bde7abf commit bbcce752dbe0afe0913000e7726267564bde7abf Author: Peter Boström <pbos@chromium.org> Date: Mon Apr 30 21:33:10 2018 Fix toolbar button insets for Touch and Refresh This change accomplishes a couple of things: * Unifies Touchable and Refresh layout inkdrop behavior. * Gets 8dp inkdrop corners for Touchable * Removes hard-coded inkdrop sizes and insets. * Makes the flood-fill inkdrop work with extended edges (toolbar edges). This was not a problem for touchable as they removed extended edges. * Changes Refresh inkdrop size to 28dps instead of inkdrop-default 24dp. * Uses flood-fill inkdrop for Refresh. * Increases toolbar horizontal padding to 8dp per specs. Bug: chromium:822069 , chromium:834511 Change-Id: I458fecfb14ca2d21dcf9513756182b2bf8e9320e Reviewed-on: https://chromium-review.googlesource.com/1033962 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#554884} [modify] https://crrev.com/bbcce752dbe0afe0913000e7726267564bde7abf/chrome/browser/ui/layout_constants.cc [modify] https://crrev.com/bbcce752dbe0afe0913000e7726267564bde7abf/chrome/browser/ui/layout_constants.h [modify] https://crrev.com/bbcce752dbe0afe0913000e7726267564bde7abf/chrome/browser/ui/views/toolbar/browser_app_menu_button.cc [modify] https://crrev.com/bbcce752dbe0afe0913000e7726267564bde7abf/chrome/browser/ui/views/toolbar/toolbar_action_view.cc [modify] https://crrev.com/bbcce752dbe0afe0913000e7726267564bde7abf/chrome/browser/ui/views/toolbar/toolbar_button.cc [modify] https://crrev.com/bbcce752dbe0afe0913000e7726267564bde7abf/chrome/browser/ui/views/toolbar/toolbar_ink_drop_util.h [modify] https://crrev.com/bbcce752dbe0afe0913000e7726267564bde7abf/chrome/browser/ui/views/toolbar/toolbar_view.cc
Done!
Comment 1 by kylixrd@chromium.org
, Apr 26 2018Owner: pbos@chromium.org
Status: Available (was: Untriaged)