Current touchable icon color: GG800 Expected touchable icon color: GG700 (or GG900 equivalent) ---- From go/chrome-ux-gm2: https://docs.google.com/presentation/d/1EO7TOpIMJ7QHjaTVw9St-q6naKwtXX2TwzMirG5EsKY/edit#slide=id.g36e7d8d795_33_93 Tearsheet: go/chrome-ux-gm2-core
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5d6fee994cc84be26d06b03ce6a38bb4e665587 commit b5d6fee994cc84be26d06b03ce6a38bb4e665587 Author: Peter Boström <pbos@chromium.org> Date: Tue May 08 02:09:45 2018 Use GG700 / Chrome icon color for toolbar Replaces GG800 with GG700 as icon color in a couple of places: * Omnibox default chip (HTTP (i) icon for instance). * BubbleIconView inside omnibar (these used to be GG700 but regressed to GG800 in Touchable / Refresh recently). * Toolbar button icons. Bug: chromium:821996, chromium:834510 Change-Id: I9e953c9da1e0eee1da132e3e0e71474ff7877aef Reviewed-on: https://chromium-review.googlesource.com/1040875 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#556646} [modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/themes/theme_properties.cc [modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/omnibox/omnibox_theme.cc [modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/location_bar/bubble_icon_view.cc [modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/location_bar/bubble_icon_view.h [modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/location_bar/find_bar_icon.cc [modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/location_bar/find_bar_icon.h [modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/location_bar/intent_picker_view.cc [modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/location_bar/intent_picker_view.h [modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/location_bar/location_bar_view.cc [modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/location_bar/location_bar_view.h [modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/location_bar/star_view.cc [modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/location_bar/star_view.h [modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/location_bar/zoom_view.cc [modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/location_bar/zoom_view.h [modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc [modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h [modify] https://crrev.com/b5d6fee994cc84be26d06b03ce6a38bb4e665587/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3 commit a6598e5db8a6aada00c8ffc6d8000ef8638e12b3 Author: Kunihiko Sakamoto <ksakamoto@chromium.org> Date: Tue May 08 05:35:37 2018 Revert "Use GG700 / Chrome icon color for toolbar" This reverts commit b5d6fee994cc84be26d06b03ce6a38bb4e665587. Reason for revert: Speculative revert for mash_browser_tests failure on linux-chromeos-rel https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/7672 Original change's description: > Use GG700 / Chrome icon color for toolbar > > Replaces GG800 with GG700 as icon color in a couple of places: > > * Omnibox default chip (HTTP (i) icon for instance). > * BubbleIconView inside omnibar (these used to be GG700 but regressed > to GG800 in Touchable / Refresh recently). > * Toolbar button icons. > > Bug: chromium:821996, chromium:834510 > Change-Id: I9e953c9da1e0eee1da132e3e0e71474ff7877aef > Reviewed-on: https://chromium-review.googlesource.com/1040875 > Commit-Queue: Peter Boström <pbos@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556646} TBR=pkasting@chromium.org,estade@chromium.org,pbos@chromium.org,bsep@chromium.org Change-Id: I1d56fd212cbe1ed50b620b61b9287cfa8abc5b48 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:821996, chromium:834510 , chromium:840657 Reviewed-on: https://chromium-review.googlesource.com/1049445 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#556700} [modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/themes/theme_properties.cc [modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/omnibox/omnibox_theme.cc [modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/location_bar/bubble_icon_view.cc [modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/location_bar/bubble_icon_view.h [modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/location_bar/find_bar_icon.cc [modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/location_bar/find_bar_icon.h [modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/location_bar/intent_picker_view.cc [modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/location_bar/intent_picker_view.h [modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/location_bar/location_bar_view.cc [modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/location_bar/location_bar_view.h [modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/location_bar/star_view.cc [modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/location_bar/star_view.h [modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/location_bar/zoom_view.cc [modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/location_bar/zoom_view.h [modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc [modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h [modify] https://crrev.com/a6598e5db8a6aada00c8ffc6d8000ef8638e12b3/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/acb195073e0f1d65cd2df44f8e129104262ce53e commit acb195073e0f1d65cd2df44f8e129104262ce53e Author: Peter Boström <pbos@chromium.org> Date: Wed May 09 01:57:39 2018 Reland "Use GG700 / Chrome icon color for toolbar" This reverts commit a6598e5db8a6aada00c8ffc6d8000ef8638e12b3. Reason for revert: Partial reland that doesn't remove caching of tint_. Original change's description: > Revert "Use GG700 / Chrome icon color for toolbar" > > This reverts commit b5d6fee994cc84be26d06b03ce6a38bb4e665587. > > Reason for revert: Speculative revert for mash_browser_tests failure on linux-chromeos-rel > https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/7672 > > Original change's description: > > Use GG700 / Chrome icon color for toolbar > > > > Replaces GG800 with GG700 as icon color in a couple of places: > > > > * Omnibox default chip (HTTP (i) icon for instance). > > * BubbleIconView inside omnibar (these used to be GG700 but regressed > > to GG800 in Touchable / Refresh recently). > > * Toolbar button icons. > > > > Bug: chromium:821996, chromium:834510 > > Change-Id: I9e953c9da1e0eee1da132e3e0e71474ff7877aef > > Reviewed-on: https://chromium-review.googlesource.com/1040875 > > Commit-Queue: Peter Boström <pbos@chromium.org> > > Reviewed-by: Peter Kasting <pkasting@chromium.org> > > Reviewed-by: Evan Stade <estade@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#556646} > > TBR=pkasting@chromium.org,estade@chromium.org,pbos@chromium.org,bsep@chromium.org > > Change-Id: I1d56fd212cbe1ed50b620b61b9287cfa8abc5b48 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:821996, chromium:834510 , chromium:840657 > Reviewed-on: https://chromium-review.googlesource.com/1049445 > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> > Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556700} TBR=pkasting@chromium.org,estade@chromium.org,bsep@chromium.org Change-Id: I280c016c9cf772ce5919c29ebee4dba8535e44e3 Bug: chromium:821996, chromium:834510 , chromium:840657 Reviewed-on: https://chromium-review.googlesource.com/1050486 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#557060} [modify] https://crrev.com/acb195073e0f1d65cd2df44f8e129104262ce53e/chrome/browser/themes/theme_properties.cc [modify] https://crrev.com/acb195073e0f1d65cd2df44f8e129104262ce53e/chrome/browser/ui/omnibox/omnibox_theme.cc [modify] https://crrev.com/acb195073e0f1d65cd2df44f8e129104262ce53e/chrome/browser/ui/views/location_bar/bubble_icon_view.cc [modify] https://crrev.com/acb195073e0f1d65cd2df44f8e129104262ce53e/chrome/browser/ui/views/location_bar/bubble_icon_view.h [modify] https://crrev.com/acb195073e0f1d65cd2df44f8e129104262ce53e/chrome/browser/ui/views/location_bar/find_bar_icon.cc [modify] https://crrev.com/acb195073e0f1d65cd2df44f8e129104262ce53e/chrome/browser/ui/views/location_bar/find_bar_icon.h [modify] https://crrev.com/acb195073e0f1d65cd2df44f8e129104262ce53e/chrome/browser/ui/views/location_bar/intent_picker_view.cc [modify] https://crrev.com/acb195073e0f1d65cd2df44f8e129104262ce53e/chrome/browser/ui/views/location_bar/intent_picker_view.h [modify] https://crrev.com/acb195073e0f1d65cd2df44f8e129104262ce53e/chrome/browser/ui/views/location_bar/location_bar_view.cc [modify] https://crrev.com/acb195073e0f1d65cd2df44f8e129104262ce53e/chrome/browser/ui/views/location_bar/location_bar_view.h [modify] https://crrev.com/acb195073e0f1d65cd2df44f8e129104262ce53e/chrome/browser/ui/views/location_bar/star_view.cc [modify] https://crrev.com/acb195073e0f1d65cd2df44f8e129104262ce53e/chrome/browser/ui/views/location_bar/star_view.h [modify] https://crrev.com/acb195073e0f1d65cd2df44f8e129104262ce53e/chrome/browser/ui/views/location_bar/zoom_view.cc [modify] https://crrev.com/acb195073e0f1d65cd2df44f8e129104262ce53e/chrome/browser/ui/views/location_bar/zoom_view.h
This doesn't cover the NTP button color which is to be done separately but the rest of them should be done.
Comment 1 by kylixrd@chromium.org
, Apr 26 2018Status: Available (was: Untriaged)