New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 834507 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DriveSpecific/FileManagerBrowserTest.Test/2, Test/4, Test/5 flake on linux-chromeos-rel

Project Member Reported by noel@chromium.org, Apr 18 2018

Issue description

DriveSpecific/FileManagerBrowserTest.Test* were re-enabled on https://crrev.com/550143 and in browser_test (with patch) three of them sometimes flake, but work on re-try, so browser_test (with patch) ends up green.  The tests are:

DriveSpecific/FileManagerBrowserTest.Test/2
DriveSpecific/FileManagerBrowserTest.Test/4
DriveSpecific/FileManagerBrowserTest.Test/5

They have run for about 10 hours and collected enough new data to work out how they fail.

TODO: disable these 3 tests again
TODO: grab build logs and record
 

Comment 1 by noel@chromium.org, Apr 18 2018

Cc: yamaguchi@chromium.org mtomasz@chromium.org fukino@chromium.org
Components: Platform>Apps>FileManager Tests>Flaky
Owner: noel@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6abcea2f6e43e43c3fa4048007ddd461f747eb9b

commit 6abcea2f6e43e43c3fa4048007ddd461f747eb9b
Author: Noel Gordon <noel@chromium.org>
Date: Thu Apr 19 00:35:45 2018

Disable DriveSpecific/FileManagerBrowserTest.Test/2/4/5 browser tests

See https://bugs.chromium.org/p/chromium/issues/detail?id=829310#c29

Bug:  834507 ,  829310 
Change-Id: Ifd37d589110f6fabd7048c231884b8c007d9ecc0
Reviewed-on: https://chromium-review.googlesource.com/1018260
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551899}
[modify] https://crrev.com/6abcea2f6e43e43c3fa4048007ddd461f747eb9b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Comment 3 by sashab@chromium.org, Apr 19 2018

Labels: CrOSFilesCategory-Testing

Comment 4 by noel@chromium.org, Apr 19 2018

Cc: lucmult@chromium.org
+lucmult, pending function, "message.replace is not a function" is the error, in the file_manager test_utils.js

Comment 5 Deleted

Comment 6 by noel@chromium.org, Apr 19 2018

Summary: DriveSpecific/FileManagerBrowserTest.Test/2, Test/4, Test/5 flake on linux-chromeos-rel (was: DriveSpecific/FileManagerBrowserTest.Test/2, Test/4 , Test/5 flake on linux-chromeos-rel)
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aeaf2ab84014754fa26b564b166ffe9a13041d91

commit aeaf2ab84014754fa26b564b166ffe9a13041d91
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Thu Apr 19 06:44:47 2018

Fix |pending| to force String type to |message| argument.

This fixes |pending| when it's called with invalid input, where it was
failing with "TypeError: message.replace is not a function" when
|message| argument was null, not provided or wrong type.

With this change the tests below no longer fail:
DriveSpecific/FileManagerBrowserTest.Test/2
DriveSpecific/FileManagerBrowserTest.Test/4
DriveSpecific/FileManagerBrowserTest.Test/5

Bug:  834507 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If060cdad8aa9d52b677947cceeadddb51068d654
Reviewed-on: https://chromium-review.googlesource.com/1018562
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551958}
[modify] https://crrev.com/aeaf2ab84014754fa26b564b166ffe9a13041d91/ui/file_manager/integration_tests/test_util.js

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93daaed987cadf2e95824e360448443b14564bc6

commit 93daaed987cadf2e95824e360448443b14564bc6
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Thu Apr 19 06:57:48 2018

Fix calls to |pending| by providing |caller| argument

Fix calls to |pending| function that weren't providing |caller|
argument. Occurrences found from code search within directory
ui/file_manager/integration_tests/file_manager/.

Bug:  834507 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iac31a0f5d11c1c70e9a4c79ddf6e558ca10c9731
Reviewed-on: https://chromium-review.googlesource.com/1018745
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551959}
[modify] https://crrev.com/93daaed987cadf2e95824e360448443b14564bc6/ui/file_manager/integration_tests/file_manager/drive_specific.js
[modify] https://crrev.com/93daaed987cadf2e95824e360448443b14564bc6/ui/file_manager/integration_tests/file_manager/open_video_files.js

Comment 9 by noel@chromium.org, Apr 19 2018

lucmult@ thanks for the quick fixes.  These 3 tests were disabled when you landed your change to the pending function: there was no test to back you up.

The new data we collected overnight identified and lead to the fix. Now these tests work locally for you, per #7, I can just revert #2.
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbc016f8498abf4d05e725bb439f5f37d1b5ddd7

commit fbc016f8498abf4d05e725bb439f5f37d1b5ddd7
Author: Noel Gordon <noel@chromium.org>
Date: Thu Apr 19 07:35:28 2018

Revert "Disable DriveSpecific/FileManagerBrowserTest.Test/2/4/5 browser tests"

This reverts commit 6abcea2f6e43e43c3fa4048007ddd461f747eb9b.

Reason for revert: Data collected overnight pointed out the problem (was due to a very recent change made while these tests were disabled). Fixed by patches landed on  issue 834507 . revert here to re-enable

  DriveSpecific/FileManagerBrowserTest.Test/2
  DriveSpecific/FileManagerBrowserTest.Test/4
  DriveSpecific/FileManagerBrowserTest.Test/5

and to find out if anything else causes them to flake.

Tbr: lucmult@
Bug:  834507 ,  829310 

Original change's description:
> Disable DriveSpecific/FileManagerBrowserTest.Test/2/4/5 browser tests
> 
> See https://bugs.chromium.org/p/chromium/issues/detail?id=829310#c29
> 
> Bug:  834507 ,  829310 
> Change-Id: Ifd37d589110f6fabd7048c231884b8c007d9ecc0
> Reviewed-on: https://chromium-review.googlesource.com/1018260
> Commit-Queue: Noel Gordon <noel@chromium.org>
> Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551899}

TBR=noel@chromium.org,yamaguchi@chromium.org

Change-Id: I284f3ae85d90916d1f9ad7485c3061419ace7565
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  834507 ,  829310 
Reviewed-on: https://chromium-review.googlesource.com/1018563
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551964}
[modify] https://crrev.com/fbc016f8498abf4d05e725bb439f5f37d1b5ddd7/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Comment 11 by noel@chromium.org, Apr 19 2018

Status: Fixed (was: Assigned)

Sign in to add a comment