New issue
Advanced search Search tips

Issue 834503 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: 3
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 822072
issue 846893



Sign in to add a comment

[Touch] Bookmarks bar updates for MD refresh

Project Member Reported by bettes@chromium.org, Apr 18 2018

Issue description

Internal padding and layout changes

---

Spec: https://docs.google.com/presentation/d/1EO7TOpIMJ7QHjaTVw9St-q6naKwtXX2TwzMirG5EsKY/edit#slide=id.g36e7d8d795_33_237

Tearsheet: go/chrome-ux-gm2-core


 
Chrome 7.png
90.2 KB View Download

Comment 1 by pbos@chromium.org, Apr 18 2018

Cc: pbos@chromium.org
Alan are these identical with the changes needed for  issue 822072 ?

Comment 2 by bettes@chromium.org, Apr 18 2018

Description: Show this description

Comment 3 by bettes@chromium.org, Apr 18 2018

This bug is for Touch UI, tracking whatever the delta is between touchable chrome and our gm2 spec

Comment 4 by bettes@chromium.org, Apr 20 2018

Macviews implementation for reference 
https://bugs.chromium.org/p/chromium/issues/detail?id=826264#c13
Status: Available (was: Untriaged)
Blockedon: 846893
EstimatedDays: 3
Owner: pbos@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0a7fd622e70bd84e27e82b6876a8fb087187574

commit e0a7fd622e70bd84e27e82b6876a8fb087187574
Author: Peter Boström <pbos@chromium.org>
Date: Thu Jun 07 00:21:21 2018

Adjust bookmark inkdrop insets for MD Refresh

This provides circular inkdrops for favicon-only bookmarks for both
Refresh and Touchable Refresh (the insets are different for the larger
buttons). As this makes the ink-drop end cap start at the center of the
favicon, this also looks significantly better for circular favicons.

The change also fixes the way-too-small insets in Touchable Refresh (as
they were overridden by Refresh in MaterialRefreshLayoutProvider).

Bug:  chromium:822072 ,  chromium:834503 
Change-Id: I12586a7588a0fb5163d25b43ebd327df65da6862
Reviewed-on: https://chromium-review.googlesource.com/1082477
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565115}
[modify] https://crrev.com/e0a7fd622e70bd84e27e82b6876a8fb087187574/chrome/browser/ui/views/harmony/material_refresh_layout_provider.cc

ping, is this done? (triage)

Comment 11 by pbos@chromium.org, Jun 7 2018

Status: Fixed (was: Assigned)
Yep!

Sign in to add a comment