[Touch] Bookmarks bar updates for MD refresh |
|||||||
Issue descriptionInternal padding and layout changes --- Spec: https://docs.google.com/presentation/d/1EO7TOpIMJ7QHjaTVw9St-q6naKwtXX2TwzMirG5EsKY/edit#slide=id.g36e7d8d795_33_237 Tearsheet: go/chrome-ux-gm2-core
,
Apr 18 2018
,
Apr 18 2018
This bug is for Touch UI, tracking whatever the delta is between touchable chrome and our gm2 spec
,
Apr 20 2018
Macviews implementation for reference https://bugs.chromium.org/p/chromium/issues/detail?id=826264#c13
,
Apr 26 2018
,
May 25 2018
,
May 29 2018
,
May 31 2018
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0a7fd622e70bd84e27e82b6876a8fb087187574 commit e0a7fd622e70bd84e27e82b6876a8fb087187574 Author: Peter Boström <pbos@chromium.org> Date: Thu Jun 07 00:21:21 2018 Adjust bookmark inkdrop insets for MD Refresh This provides circular inkdrops for favicon-only bookmarks for both Refresh and Touchable Refresh (the insets are different for the larger buttons). As this makes the ink-drop end cap start at the center of the favicon, this also looks significantly better for circular favicons. The change also fixes the way-too-small insets in Touchable Refresh (as they were overridden by Refresh in MaterialRefreshLayoutProvider). Bug: chromium:822072 , chromium:834503 Change-Id: I12586a7588a0fb5163d25b43ebd327df65da6862 Reviewed-on: https://chromium-review.googlesource.com/1082477 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#565115} [modify] https://crrev.com/e0a7fd622e70bd84e27e82b6876a8fb087187574/chrome/browser/ui/views/harmony/material_refresh_layout_provider.cc
,
Jun 7 2018
ping, is this done? (triage)
,
Jun 7 2018
Yep! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by pbos@chromium.org
, Apr 18 2018