New issue
Advanced search Search tips

Issue 834487 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

WindowMusType::EMBED_IN_OWNER is not consistently set

Project Member Reported by sky@chromium.org, Apr 18 2018

Issue description

For any of the Embed() variants we need to ensure EMBED_IN_OWNER is correctly set, otherwise it's confusing and I think currently some things are broke.
 
Labels: Proj-Mash-SingleProcess
Owner: sky@chromium.org
Status: Assigned (was: Available)
This make not directly impact single process mash, but I have no doubt it's a source of some bugs. Ideally it would be nice to remove EMBED_IN_OWNER entirely as it's more of a run-time setting, where as the others are for the life of the window.
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7cb691818ee484d971ee39a5a57b410ec5fc660

commit a7cb691818ee484d971ee39a5a57b410ec5fc660
Author: Scott Violet <sky@chromium.org>
Date: Tue Oct 02 16:07:58 2018

window-service: removes EMBED_IN_OWNER

And replaces it with a boolean. This makes more sense as EMBED_IN_OWNER is
really something that changes depending upon whether the Window has an embedding
or not.

BUG= 834487 
TEST=covered by tests

Change-Id: If5d46331b1c54e329247996f3fc012448435aabf
Reviewed-on: https://chromium-review.googlesource.com/1239371
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595861}
[modify] https://crrev.com/a7cb691818ee484d971ee39a5a57b410ec5fc660/ash/ash_service_unittest.cc
[modify] https://crrev.com/a7cb691818ee484d971ee39a5a57b410ec5fc660/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/a7cb691818ee484d971ee39a5a57b410ec5fc660/ui/aura/BUILD.gn
[modify] https://crrev.com/a7cb691818ee484d971ee39a5a57b410ec5fc660/ui/aura/client/aura_constants.cc
[modify] https://crrev.com/a7cb691818ee484d971ee39a5a57b410ec5fc660/ui/aura/client/aura_constants.h
[modify] https://crrev.com/a7cb691818ee484d971ee39a5a57b410ec5fc660/ui/aura/env.cc
[modify] https://crrev.com/a7cb691818ee484d971ee39a5a57b410ec5fc660/ui/aura/hit_test_data_provider_aura_unittest.cc
[modify] https://crrev.com/a7cb691818ee484d971ee39a5a57b410ec5fc660/ui/aura/mus/mus_types.h
[modify] https://crrev.com/a7cb691818ee484d971ee39a5a57b410ec5fc660/ui/aura/mus/window_port_mus.cc
[modify] https://crrev.com/a7cb691818ee484d971ee39a5a57b410ec5fc660/ui/aura/mus/window_port_mus.h
[modify] https://crrev.com/a7cb691818ee484d971ee39a5a57b410ec5fc660/ui/aura/mus/window_port_mus_unittest.cc
[modify] https://crrev.com/a7cb691818ee484d971ee39a5a57b410ec5fc660/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/a7cb691818ee484d971ee39a5a57b410ec5fc660/ui/aura/mus/window_tree_client.h
[modify] https://crrev.com/a7cb691818ee484d971ee39a5a57b410ec5fc660/ui/aura/mus/window_tree_client_unittest.cc
[add] https://crrev.com/a7cb691818ee484d971ee39a5a57b410ec5fc660/ui/aura/test/mus/window_port_mus_test_helper.cc
[add] https://crrev.com/a7cb691818ee484d971ee39a5a57b410ec5fc660/ui/aura/test/mus/window_port_mus_test_helper.h
[modify] https://crrev.com/a7cb691818ee484d971ee39a5a57b410ec5fc660/ui/views/mus/remote_view/remote_view_host.cc

Status: Fixed (was: Started)

Sign in to add a comment