New issue
Advanced search Search tips

Issue 834480 link

Starred by 1 user
Status: Fixed
Owner:
no...@chromium.org
Closed: Apr 2018
Cc:
no...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

buildbucket: set_next_build_number API doesn't verify that builder exists

Project Member Reported by bpastene@chromium.org, Apr 18 2018 
To replicate, type in a bogus buildername in the request:
https://apis-explorer.appspot.com/apis-explorer/?base=https://cr-buildbucket.appspot.com/_ah/api#p/swarmbucket/v1/swarmbucket.set_next_build_number

And it returns a 204. Should probably return a 400 or something if the builder doesn't exist?

Comment 1 by no...@chromium.org, Apr 23 2018

Owner: no...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7dfea7bc0e6364e28b350c3b7dd4f0d2db9c9c01

commit 7dfea7bc0e6364e28b350c3b7dd4f0d2db9c9c01
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Apr 24 01:00:21 2018

[buildbucket] set_next_build_number: check that builder exists

R=tandrii@chromium.org

Bug:  834480 
Change-Id: Ic9d29ee251bd7ac2d5c6e6080278f973ecd4292b
Reviewed-on: https://chromium-review.googlesource.com/1024638
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/7dfea7bc0e6364e28b350c3b7dd4f0d2db9c9c01/appengine/cr-buildbucket/swarming/test/swarmbucket_api_test.py
[modify] https://crrev.com/7dfea7bc0e6364e28b350c3b7dd4f0d2db9c9c01/appengine/cr-buildbucket/swarming/swarmbucket_api.py

Comment 4 by no...@chromium.org, Apr 24 2018

Status: Fi (was: Started)

Comment 5 by no...@chromium.org, Apr 24 2018

Status: Fixed (was: fi)
►

Sign in to add a comment