After triggering https://ci.chromium.org/p/chromium/builders/luci.chromium.findit/findit_variable/1944 and https://ci.chromium.org/p/chromium/builders/luci.chromium.findit/findit_variable/1945 , and having both builds completed, the build aheads handler still considers it in progress: https://pantheon.corp.google.com/logs/viewer?expandAll=false&project=findit-for-me&minLogLevel=0×tamp=2018-04-18T21%3A29%3A37.574000000Z&customFacets&advancedFilter=resource.type%3D%22gae_app%22%0Aresource.labels.module_id%3D%22waterfall-backend%22%0Aresource.labels.zone%3D%22us14%22%0Aresource.labels.project_id%3D%22findit-for-me%22%0Aresource.labels.version_id%3D%2215030-2a14734%22%0Atimestamp%3D%222018-04-18T21%3A29%3A25.682781000Z%22%0AinsertId%3D%225ad7b8b6000ea78cb857329d%22&dateRangeStart=2018-04-18T20%3A29%3A32.631Z&interval=PT1H&dateRangeUnbound=forwardInTime&scrollTimestamp=2018-04-18T21%3A29%3A25.682781000Z
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/c83edda6822ce3663678a57ecfb2125f29882708 commit c83edda6822ce3663678a57ecfb2125f29882708 Author: Roberto Carrillo <robertocn@google.com> Date: Wed Apr 18 22:53:29 2018 [Findit] Make MarkComplete persist the build ahead try job record. As soon as MarkComplete is called, we should persist the state of the try job so that any failure in the handler does not make it lose this knowledge. R=chanli,lijeffrey,stgao Bug: 834473 Change-Id: I0407eb1a6c5221400c22ccb2561169f808bda803 Reviewed-on: https://chromium-review.googlesource.com/1018000 Reviewed-by: Shuotao Gao <stgao@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> [modify] https://crrev.com/c83edda6822ce3663678a57ecfb2125f29882708/appengine/findit/model/test/build_ahead_try_job_test.py [modify] https://crrev.com/c83edda6822ce3663678a57ecfb2125f29882708/appengine/findit/model/build_ahead_try_job.py
Comment 1 by bugdroid1@chromium.org
, Apr 18 2018