Change |kRlzEmbargoEndDateGarbageDateThresholdDays| back to 14 days |
||||||
Issue descriptionThe current value (7) did not consider the possibility of, e.g. the factory clock is ahead by one hour. (Then the embargo date would be set to 7d+1h which then would be ignored if the device was tested immediately after being produced.) Changing it back to 14 days makes sense. So CL 1007962 should be reverted.
,
Apr 18 2018
Requesting merge to M67.
,
Apr 19 2018
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 20 2018
Approving merge to M67 Chrome OS.
,
Apr 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48bcd0f6abbe1d7af586a9746b212551ce1eb7f0 commit 48bcd0f6abbe1d7af586a9746b212551ce1eb7f0 Author: Wenzhao Zang <wzang@chromium.org> Date: Fri Apr 20 19:06:17 2018 [M67 merge] Revert "cros: Update |kRlzEmbargoEndDateGarbageDateThresholdDays| value" This reverts commit 49597ae9219642ddedd67fc6c4259b17b0df1237. Reason for revert: crbug.com/834468 Original change's description: > cros: Update |kRlzEmbargoEndDateGarbageDateThresholdDays| value > > Because the factory already adds 7 days to the actual date, the > threshold should only add 7 days to rlz_embargo_end_date. > > Bug: 820783 > Change-Id: I97a599b2f893493ac91910f449051ec5a0ea7807 > Reviewed-on: https://chromium-review.googlesource.com/1007962 > Reviewed-by: Roger Tawa <rogerta@chromium.org> > Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550016} TBR=rogerta@chromium.org, wzang@chromium.org (cherry picked from commit 2ee39b4d658f3f1c4d6479e337518de2c964810b) Bug: 820783, 834468 Change-Id: Iba80c9efc398f5654f814e38aa097932e8aa16e8 Reviewed-on: https://chromium-review.googlesource.com/1017666 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#551868} Reviewed-on: https://chromium-review.googlesource.com/1022471 Cr-Commit-Position: refs/branch-heads/3396@{#169} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/48bcd0f6abbe1d7af586a9746b212551ce1eb7f0/rlz/chromeos/lib/rlz_value_store_chromeos.cc
,
Apr 20 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Apr 18 2018