The background color of the title string in CustomFrameViewAsh sometimes inconsistent |
||||||||
Issue descriptionRepro step: 1) Enable chrome caption for ARC++ (Android Settings -> Developer options -> Enable chrome caption 2) Install Evernote app and start. If this happens only if the string is set, then we don't have to merge to 67.
,
Apr 20 2018
,
Apr 20 2018
,
Apr 24 2018
It is because the view does not schedule paint. I will upload cl soon.
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/afa6dbe0221f694c227b620b6e201383d115f544 commit afa6dbe0221f694c227b620b6e201383d115f544 Author: wutao <wutao@chromium.org> Date: Wed Apr 25 17:15:56 2018 cros: Update background color of frame view. Somes time the background color of the title string in CustomFrameViewAsh does not update. This cl fixes this bug. Bug: 834465 Test: Manual. Change-Id: Iee99678c0a947f4db8cbb06611f2fca0600cd72d Reviewed-on: https://chromium-review.googlesource.com/1024606 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#553617} [modify] https://crrev.com/afa6dbe0221f694c227b620b6e201383d115f544/ash/frame/default_frame_header.cc
,
Apr 25 2018
,
Apr 25 2018
,
Apr 26 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c104a65fdff9596b011602f8e6f819bd8fc2738 commit 4c104a65fdff9596b011602f8e6f819bd8fc2738 Author: wutao <wutao@chromium.org> Date: Thu Apr 26 18:07:03 2018 M67 merge: cros: Update background color of frame view. Somes time the background color of the title string in CustomFrameViewAsh does not update. This cl fixes this bug. TBR=oshima@chromium.org Bug: 834465 Test: Manual. Change-Id: Iee99678c0a947f4db8cbb06611f2fca0600cd72d Reviewed-on: https://chromium-review.googlesource.com/1024606 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#553617}(cherry picked from commit afa6dbe0221f694c227b620b6e201383d115f544) Reviewed-on: https://chromium-review.googlesource.com/1030788 Reviewed-by: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#332} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/4c104a65fdff9596b011602f8e6f819bd8fc2738/ash/frame/default_frame_header.cc
,
May 24 2018
Verified on M68 (10715.0.0, 68.0.3438.0). |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by osh...@chromium.org
, Apr 19 2018