New issue
Advanced search Search tips

Issue 834458 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature


Participants' hotlists:
Modern-Media-Controls


Sign in to add a comment

Media Controls VR: Use separate stylesheet instead of media query

Project Member Reported by steimel@chromium.org, Apr 18 2018

Issue description

Since the immersive media query is having issues, we should just move the VR-specific CSS rules to a new stylesheet that is only loaded when immersive mode is enabled
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 21 2018

Labels: Merge-Request-67
Status: Fixed (was: Started)

Comment 3 by gov...@chromium.org, Apr 23 2018

Pls add appropriate OSs label. Thank you.
Labels: OS-Android

Comment 5 by cmasso@google.com, Apr 23 2018

Please confirm the fix works in canary.
Just checked and it works. Thanks!
Project Member

Comment 7 by sheriffbot@chromium.org, Apr 24 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 25 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b36c08dcbdb9c76b6db9cac71afd1e4ee38595c2

commit b36c08dcbdb9c76b6db9cac71afd1e4ee38595c2
Author: Tommy Steimel <steimel@chromium.org>
Date: Wed Apr 25 21:47:56 2018

Depend on CSS class for VR styling instead of media query

This CL changes the VR-specific CSS rules for modern media controls to
use an "immersive-mode" class instead of depending on the broken media
query.

Bug:  834458 
Change-Id: Ic73d1a78167bc9afaa6266bf13e85625b60f95bd
Reviewed-on: https://chromium-review.googlesource.com/1020400
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552554}(cherry picked from commit e3e69ba5bf65da68569f6376d338191e16259bc9)
Reviewed-on: https://chromium-review.googlesource.com/1028950
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#313}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[add] https://crrev.com/b36c08dcbdb9c76b6db9cac71afd1e4ee38595c2/third_party/WebKit/LayoutTests/media/controls/modern/immersive-mode-adds-css-class.html
[modify] https://crrev.com/b36c08dcbdb9c76b6db9cac71afd1e4ee38595c2/third_party/WebKit/LayoutTests/media/media-controls.js
[modify] https://crrev.com/b36c08dcbdb9c76b6db9cac71afd1e4ee38595c2/third_party/blink/renderer/core/frame/settings.json5
[modify] https://crrev.com/b36c08dcbdb9c76b6db9cac71afd1e4ee38595c2/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
[modify] https://crrev.com/b36c08dcbdb9c76b6db9cac71afd1e4ee38595c2/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css

Sign in to add a comment