WorkletAnimation constructor should throw when given multiple effects |
||||
Issue descriptionOur current implementation of Animation Worklet only supports single elements. The constructor also accepts a sequence of effects, in which case our current implementation only processes the first effect. We should log a warning (or throw) when an array with more than one item is passed to the WorkletAnimation constructor.
,
Apr 24 2018
I think we should throw instead of just a warning. It is not supported yet so it will be confusing if we accept multiple effects and just animate a single one!
,
Apr 24 2018
That was my original intuition as well, so sgtm :)
,
Apr 24 2018
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a757c32aef263b1851e62d20285cccd1e28da4f5 commit a757c32aef263b1851e62d20285cccd1e28da4f5 Author: Yi Gu <yigu@chromium.org> Date: Tue Apr 24 17:15:07 2018 Log error upon attempting to animate multiple effects Animating multiple effects is not fully supported yet (tracked via crbug.com/767043). For origin trial we should log a warning when an array with multiple effects is passed to the WorkletAnimation constructor. Bug: 834456 Change-Id: Ie0a37e0d36464e595b54f140d2e3f3331280dd61 Reviewed-on: https://chromium-review.googlesource.com/1024952 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#553182} [modify] https://crrev.com/a757c32aef263b1851e62d20285cccd1e28da4f5/third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/worklet-animation-creation.html [modify] https://crrev.com/a757c32aef263b1851e62d20285cccd1e28da4f5/third_party/blink/renderer/modules/animationworklet/worklet_animation.cc
,
Apr 24 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by yigu@chromium.org
, Apr 19 2018Labels: -Type-Bug HotlistHotlist-AnimationWorklet Type-Feature
Owner: yigu@chromium.org
Status: Assigned (was: Unconfirmed)