When the device is in tablet mode, tapping the power button currently turns the screen off. I'm not sure if this makes sense or if we should also dismiss the menu in this case. Does anyone else have opinions?

Re: we already dismiss menu when backlights forced off changed: https://cs.chromium.org/chromium/src/ash/system/power/power_button_controller.cc?sq=package:chromium&l=404

> we already dismiss menu when backlights forced off changed

Sorry, I think that my wording was unclear. What I'm wondering is:

When the power menu is open on a device in tablet mode, should tapping the power button *close the menu but keep the screen on*?

Right now, tapping the power button in this scenario both closes the menu and turns the screen off.

I've sent https://crrev.com/c/1020376 to do the tapping-in-laptop-mode-dismisses-menu part of this, which I suspect will be noncontroversial.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f39bd0d16eb52cefbe99f51797c8b17709c26e29

commit f39bd0d16eb52cefbe99f51797c8b17709c26e29
Author: Daniel Erat <derat@chromium.org>
Date: Fri Apr 20 00:24:53 2018

chromeos: Make power button tap dismiss menu in laptop mode.

Make tapping the power button dismiss the power menu while
in laptop mode. Previously, tapping the power button was a
no-op in this case.

The menu remains visible if the power button is held long
enough to start the cancellable shutdown animation.

Bug:  834447 
Change-Id: I8761d846b334ce3712bc1062b609988b12c5b547
Reviewed-on: https://chromium-review.googlesource.com/1020376
Reviewed-by: Min Chen <minch@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552213}
[modify] https://crrev.com/f39bd0d16eb52cefbe99f51797c8b17709c26e29/ash/system/power/power_button_controller.cc
[modify] https://crrev.com/f39bd0d16eb52cefbe99f51797c8b17709c26e29/ash/system/power/power_button_controller_unittest.cc

Requesting a merge to M67. This is a small refinement to new power button behavior that will go out with this release. I think it will help mitigate accidental power button presses. I've verified the change on ToT.

Hi Dan, appears to be more of a feature than a regression bug.  Would rather wait for M68 unless you think it's disruptive otherwise.

I feel that leaving this out will be disruptive to users. I also see it as part of the larger power button menu feature that's first shipping in M67 (issue 732628), so I'd like it to be included in the same release.

+1 to #7

Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ebcec3f64e7c1680e7ef930ffad9e27e4e8e364

commit 1ebcec3f64e7c1680e7ef930ffad9e27e4e8e364
Author: Daniel Erat <derat@chromium.org>
Date: Tue Apr 24 21:50:53 2018

chromeos: Make power button tap dismiss menu in laptop mode.

Make tapping the power button dismiss the power menu while
in laptop mode. Previously, tapping the power button was a
no-op in this case.

The menu remains visible if the power button is held long
enough to start the cancellable shutdown animation.

Bug:  834447 
Change-Id: I8761d846b334ce3712bc1062b609988b12c5b547
Reviewed-on: https://chromium-review.googlesource.com/1020376
Reviewed-by: Min Chen <minch@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552213}(cherry picked from commit f39bd0d16eb52cefbe99f51797c8b17709c26e29)
Reviewed-on: https://chromium-review.googlesource.com/1026434
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#267}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/1ebcec3f64e7c1680e7ef930ffad9e27e4e8e364/ash/system/power/power_button_controller.cc
[modify] https://crrev.com/1ebcec3f64e7c1680e7ef930ffad9e27e4e8e364/ash/system/power/power_button_controller_unittest.cc

Thanks!