It is consistently failing on my unrelated CL: https://chromium-review.googlesource.com/c/chromium/src/+/999032 It has at least failed once in another build: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests%20(with%20patch)&tests=http%2Ftests%2Fmisc%2Fperformance-memory.html Perhaps the failure is related to the ordering of tests which can explain why it is consistently failing in my CL.
Seems to have a more frequent failure rate when site-per-process is enabled: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=site_per_process_webkit_layout_tests%20(with%20patch)&tests=http%2Ftests%2Fmisc%2Fperformance-memory.html
Here is another failure: https://test-results.appspot.com/data/layout_results/linux_chromium_rel_ng/73164/site_per_process_webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html
/cc horo@ since I believe their CL may also have been affected by this: https://chromium-review.googlesource.com/c/chromium/src/+/1014744/8 I have a CL to mark this test as flaky on linux. https://chromium-review.googlesource.com/c/chromium/src/+/1017816
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a99766226185009aa064d195baaaf8b9d5ed7150 commit a99766226185009aa064d195baaaf8b9d5ed7150 Author: Majid Valipour <majidvp@chromium.org> Date: Wed Apr 18 22:29:44 2018 Mark http/tests/misc/performance-memory.html flaky TBR=npm@chromium.org BUG: 834446 Change-Id: Ia4315e380833ba43908dddd17a1f67125445b2ab Reviewed-on: https://chromium-review.googlesource.com/1017816 Reviewed-by: Majid Valipour <majidvp@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#551857} [modify] https://crrev.com/a99766226185009aa064d195baaaf8b9d5ed7150/third_party/WebKit/LayoutTests/TestExpectations
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c7847f69de403f6c798dfccba10812039a60480 commit 7c7847f69de403f6c798dfccba10812039a60480 Author: Nicolas Pena <npm@chromium.org> Date: Wed May 30 01:36:05 2018 performance.memory: report precise values when locked to site This CL plumbs to Blink whether the renderer process is locked to a site (a scheme plus eTLD+1, like https://google.com) or to other more granular lock. This is used by MemoryInfo to report precise data when the process is locked to an origin. The data is still cached / delayed, but not as much as in the bucketized case. This CL also changes |total_js_heap_size|, see https://chromium-review.googlesource.com/c/chromium/src/+/1020140 The two changes are aggregated in the same CL to ensure the bump to performance.memory occurs only once. Bug: 807651, 834446 Change-Id: I17917769b43c45172a54cddc5215702ce6032008 Reviewed-on: https://chromium-review.googlesource.com/1012502 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#562688} [modify] https://crrev.com/7c7847f69de403f6c798dfccba10812039a60480/content/browser/child_process_security_policy_impl.h [modify] https://crrev.com/7c7847f69de403f6c798dfccba10812039a60480/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/7c7847f69de403f6c798dfccba10812039a60480/content/browser/renderer_host/render_process_host_impl.h [modify] https://crrev.com/7c7847f69de403f6c798dfccba10812039a60480/content/browser/renderer_host/render_process_host_unittest.cc [modify] https://crrev.com/7c7847f69de403f6c798dfccba10812039a60480/content/browser/service_worker/embedded_worker_test_helper.cc [modify] https://crrev.com/7c7847f69de403f6c798dfccba10812039a60480/content/browser/site_instance_impl.cc [modify] https://crrev.com/7c7847f69de403f6c798dfccba10812039a60480/content/browser/site_instance_impl.h [modify] https://crrev.com/7c7847f69de403f6c798dfccba10812039a60480/content/browser/site_instance_impl_unittest.cc [modify] https://crrev.com/7c7847f69de403f6c798dfccba10812039a60480/content/common/renderer.mojom [modify] https://crrev.com/7c7847f69de403f6c798dfccba10812039a60480/content/public/browser/render_process_host.h [modify] https://crrev.com/7c7847f69de403f6c798dfccba10812039a60480/content/public/common/web_preferences.h [modify] https://crrev.com/7c7847f69de403f6c798dfccba10812039a60480/content/public/test/mock_render_process_host.cc [modify] https://crrev.com/7c7847f69de403f6c798dfccba10812039a60480/content/public/test/mock_render_process_host.h [modify] https://crrev.com/7c7847f69de403f6c798dfccba10812039a60480/content/renderer/render_thread_impl.cc [modify] https://crrev.com/7c7847f69de403f6c798dfccba10812039a60480/content/renderer/render_thread_impl.h [modify] https://crrev.com/7c7847f69de403f6c798dfccba10812039a60480/content/renderer/renderer_blink_platform_impl.cc [modify] https://crrev.com/7c7847f69de403f6c798dfccba10812039a60480/content/renderer/renderer_blink_platform_impl.h [modify] https://crrev.com/7c7847f69de403f6c798dfccba10812039a60480/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/7c7847f69de403f6c798dfccba10812039a60480/third_party/blink/public/platform/platform.h [modify] https://crrev.com/7c7847f69de403f6c798dfccba10812039a60480/third_party/blink/renderer/core/inspector/main_thread_debugger.cc [modify] https://crrev.com/7c7847f69de403f6c798dfccba10812039a60480/third_party/blink/renderer/core/timing/memory_info.cc [modify] https://crrev.com/7c7847f69de403f6c798dfccba10812039a60480/third_party/blink/renderer/core/timing/memory_info.h [modify] https://crrev.com/7c7847f69de403f6c798dfccba10812039a60480/third_party/blink/renderer/core/timing/memory_info_test.cc [modify] https://crrev.com/7c7847f69de403f6c798dfccba10812039a60480/third_party/blink/renderer/core/timing/window_performance.cc
I've fixed the test and reenabled. Feel free to reopen if you see it being flaky again.
Comment 1 by majidvp@chromium.org
, Apr 18 2018