One more question. Do we want to show PlayStore ToS for this case or we can start ARC directly when this flag is on?

#1 - Per offline chat ToS is needed for first run

CL - crrev.com/c/1023068

Quick clarification: tbuckley@, did you mean;

Even if a user keeps ARC enabled, ARC user data needs to be removed on "sign-out from ChromeOS then sign-in back" just for crostini demo?

Or, are there more cases?

Also the approach of crrev.com/c/1023068 requires to add commandline flag on devices. Could you double check if it works for you, just in case?

This flag and feature will be used just for the demo during I/O. I have a plan to revert this once it is no longer needed, so it should not come to any branch.

From my point there is no privacy concern.  tbuckley@, please feel free to comment too. Also initial task was to clean up on sign-out. However we can not guarantee that clean sign-out happens always. That is why we need care about such cases and also remove data on next start.

Removing data on sign-in is easier and anyway required so clean-up on sign-out is dropped, once task requirements are satisfied by removing data on next sign-in. 

 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95bfb719974e0e14593a0641110a8292b9c89c2b

commit 95bfb719974e0e14593a0641110a8292b9c89c2b
Author: khmel@google.com <khmel@google.com>
Date: Wed Apr 25 06:06:28 2018

arc: Add ability clean up data folder on each start.

Test: unit_test + manually
Bug:  834439 
Change-Id: Id3bee682062eeacf7f88ea079ea37bdd4cafe09e
Reviewed-on: https://chromium-review.googlesource.com/1023068
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Yury Khmel <khmel@google.com>
Cr-Commit-Position: refs/heads/master@{#553463}
[modify] https://crrev.com/95bfb719974e0e14593a0641110a8292b9c89c2b/chrome/browser/chromeos/arc/arc_play_store_enabled_preference_handler.cc
[modify] https://crrev.com/95bfb719974e0e14593a0641110a8292b9c89c2b/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
[modify] https://crrev.com/95bfb719974e0e14593a0641110a8292b9c89c2b/chromeos/chromeos_switches.cc
[modify] https://crrev.com/95bfb719974e0e14593a0641110a8292b9c89c2b/chromeos/chromeos_switches.h
[modify] https://crrev.com/95bfb719974e0e14593a0641110a8292b9c89c2b/components/arc/arc_util.cc
[modify] https://crrev.com/95bfb719974e0e14593a0641110a8292b9c89c2b/components/arc/arc_util.h

we should use "arc-data-cleanup-on-start" switch to activate this mode.

We no longer this flag?

I suppose not, @tbuckely, could you please confirm.