Omnibox - Keyboard is positioned incorrectly wrt Omnibox edit input field. |
|||||||
Issue descriptionChrome Version: 67.0.3396.8 Dev OS: Android 8.1.0 on Pixel 2 What steps will reproduce the problem? (1) Navigate to https://www.google.com (2) Enter VR Browsing (3) Click on the Omnibox URL to trigger keyboard entry. What is the expected result? Per Keyboard spec, center of the main panel should be 0.2m in front of the search box UI. https://docs.google.com/presentation/d/1zEm-5v1lLIOfuEbKPaWVHNNDeEks0Lr3RdiCc3cqZVs/edit#slide=id.g14ac27d193_1_29 What happens instead? Keyboard is at wrong z-depth vs Omnibox edit input field.
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/856e38c64e578afc11fd372ea36574ff3d308830 commit 856e38c64e578afc11fd372ea36574ff3d308830 Author: Ian Vollick <vollick@chromium.org> Date: Thu Apr 19 17:54:51 2018 [vr] If padding doesn't affect bounds, nor should it centering/anchoring Previously, if a shadow had set anchoring or centering, the size of the shadow would have affected the positioning. This should not be true; centering and anchoring should proceed as if there were no shadow at all. We have the property bounds_contain_padding that captures this concept in other contexts and this CL applies that notion to centering and anchoring. Bug: 834432 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I79465951c50374174710d7d76dc70d3e9cd6bdea Reviewed-on: https://chromium-review.googlesource.com/1019600 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#552080} [modify] https://crrev.com/856e38c64e578afc11fd372ea36574ff3d308830/chrome/browser/vr/elements/ui_element.cc [modify] https://crrev.com/856e38c64e578afc11fd372ea36574ff3d308830/chrome/browser/vr/elements/ui_element_unittest.cc
,
Apr 19 2018
,
Apr 20 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b55dffc815934f462ea4c301db61dbb36c2ac0cd commit b55dffc815934f462ea4c301db61dbb36c2ac0cd Author: Ian Vollick <vollick@chromium.org> Date: Fri Apr 20 23:51:05 2018 [vr] If padding doesn't affect bounds, nor should it centering/anchoring Previously, if a shadow had set anchoring or centering, the size of the shadow would have affected the positioning. This should not be true; centering and anchoring should proceed as if there were no shadow at all. We have the property bounds_contain_padding that captures this concept in other contexts and this CL applies that notion to centering and anchoring. Bug: 834432 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I79465951c50374174710d7d76dc70d3e9cd6bdea Reviewed-on: https://chromium-review.googlesource.com/1019600 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#552080}(cherry picked from commit 856e38c64e578afc11fd372ea36574ff3d308830) Reviewed-on: https://chromium-review.googlesource.com/1023150 Reviewed-by: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#188} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/b55dffc815934f462ea4c301db61dbb36c2ac0cd/chrome/browser/vr/elements/ui_element.cc [modify] https://crrev.com/b55dffc815934f462ea4c301db61dbb36c2ac0cd/chrome/browser/vr/elements/ui_element_unittest.cc
,
Apr 21 2018
,
Apr 23 2018
Fix verified on build 67.0.3396.16. Looks good.
,
Apr 24 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by vollick@chromium.org
, Apr 19 2018Owner: vollick@chromium.org
Status: Started (was: Untriaged)
Summary: Omnibox - Keyboard is positioned incorrectly wrt Omnibox edit input field. (was: Omnibox - Keyboard is at wrong z-depth vs Omnibox edit input field.)