New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 834416 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

video_VEAPerf fails at VideoEncodeAcceleratorTest.TestSimpleEncode

Project Member Reported by shenghao@chromium.org, Apr 18 2018

Issue description

10592.0.0
peach_pit, peach_pi, elm

04/17 15:35:45.968 ERROR|     video_VEAPerf:0339| 1 failures; <SimpleEncode/VideoEncodeAcceleratorTest.TestSimpleEncode/0>: ../../../../../../../home/chrome-bot/chrome_root/src/media/gpu/video_encode_accelerator_unittest.cc:2347; Expected equality of these values:;   state;     Which is: 4;   notes[i]->Wait();     Which is: 7
Traceback (most recent call last):
  File "/usr/local/autotest/tests/video_VEAPerf/video_VEAPerf.py", line 336, in run_once
    self._run_test_case(test_name, test_stream_data)
  File "/usr/local/autotest/tests/video_VEAPerf/video_VEAPerf.py", line 311, in _run_test_case
    self.run_chrome_test_binary(VEA_BINARY, ' '.join(vea_args))
  File "/usr/local/autotest/cros/chrome_binary_test.py", line 131, in run_chrome_test_binary
    raise error.TestFail(self.parse_fail_reason(e, gtest_xml))
TestFail: 1 failures; <SimpleEncode/VideoEncodeAcceleratorTest.TestSimpleEncode/0>: ../../../../../../../home/chrome-bot/chrome_root/src/media/gpu/video_encode_accelerator_unittest.cc:2347; Expected equality of these values:;   state;     Which is: 4;   notes[i]->Wait();     Which is: 7

Complete log:
https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/192541581-chromeos-test/chromeos2-row7-rack8-host15/
https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/192652126-chromeos-test/chromeos6-row2-rack9-host16
https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/192658317-chromeos-test/chromeos6-row2-rack10-host13/



 

Comment 1 by hiroh@chromium.org, Apr 18 2018

Cc: hiroh@chromium.org posciak@chromium.org
Owner: akahuang@chromium.org
Aka, could you take a look?
Even after crosreview.com/1002335, video_VEAPerf fails on some platforms.
video_VideoEncodeAcclerator fails on less platforms than video_VEAPerf. 
Please take a look both of them.
https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/testDetails?testName=video_VEAPerf
https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/testDetails?testName=video_VideoEncodeAccelerator
OK I will handle it.
Found the bug: we call the binary in 3 places, but I only added "--disable_flush" at 2 places. Now I moved the common arguments to a method.

https://chromium-review.googlesource.com/#/c/chromiumos/third_party/autotest/+/1018743/
Labels: Merge-Request-67
This CL is for fixing the autotest. Please approve to merge back to R67.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bcbf88ba666987e9368a8e8458236da443da17ec

commit bcbf88ba666987e9368a8e8458236da443da17ec
Author: Chih-Yu Huang <akahuang@google.com>
Date: Fri Apr 20 07:32:59 2018

video_VEAPerf: Add the missing argument.

We should add "--disable_flush" argument for each run of vea unittest,
but we missed to add this argument for the third run. This CL moved
the common part of argument to method to avoid this bug occurs again.

BUG= chromium:834416 
TEST=passed video_VEAPerf autotest at peach_pit device

Change-Id: If3ac3bff341ac0623d1a38843f8e8bade12e1f75
Reviewed-on: https://chromium-review.googlesource.com/1018743
Commit-Ready: Chih-Yu Huang <akahuang@chromium.org>
Tested-by: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>

[modify] https://crrev.com/bcbf88ba666987e9368a8e8458236da443da17ec/client/site_tests/video_VEAPerf/video_VEAPerf.py

Labels: -Merge-Request-67 Merge-Approved-67 M-67
Approving merge to M67 Chrome OS.
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 23 2018

Labels: merge-merged-release-R67-10575.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5be7da85abc0ce8f61b10c4c07e18e84159962cb

commit 5be7da85abc0ce8f61b10c4c07e18e84159962cb
Author: Chih-Yu Huang <akahuang@google.com>
Date: Mon Apr 23 03:05:39 2018

video_VEAPerf: Add the missing argument.

We should add "--disable_flush" argument for each run of vea unittest,
but we missed to add this argument for the third run. This CL moved
the common part of argument to method to avoid this bug occurs again.

BUG= chromium:834416 
TEST=passed video_VEAPerf autotest at peach_pit device

Change-Id: If3ac3bff341ac0623d1a38843f8e8bade12e1f75
Reviewed-on: https://chromium-review.googlesource.com/1018743
Commit-Ready: Chih-Yu Huang <akahuang@chromium.org>
Tested-by: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
(cherry picked from commit bcbf88ba666987e9368a8e8458236da443da17ec)
Reviewed-on: https://chromium-review.googlesource.com/1023670
Reviewed-by: Chih-Yu Huang <akahuang@chromium.org>
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>

[modify] https://crrev.com/5be7da85abc0ce8f61b10c4c07e18e84159962cb/client/site_tests/video_VEAPerf/video_VEAPerf.py

Status: Verified (was: Assigned)
The test went green from 10601.0.0. Close the issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Apr 25 2018

Cc: kbleicher@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 11 by hiroh@chromium.org, Apr 25 2018

Labels: -Merge-Approved-67

Sign in to add a comment