New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 834407 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-05-08
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 2
Type: Task



Sign in to add a comment

Update Public Suffix for M-67 before Stable

Project Member Reported by marti...@chromium.org, Apr 18 2018

Issue description

(Reposting explanation from Umbrella Bug, Issue 610495)

Chrome ships a copy of the Public Suffix List ( https://publicsuffix.org ) for a variety of security purposes. Because it's key to web origin security, it needs to be reliably available before any networking, and is thus baked into the binary (rather than a component updater).

The list changes over time, and so this list must be updated every release to include the latest changes.

This is a data file-only change that includes the expressed security policies of domain holders, from the domain holders.

For every release, a bug will be created to track that releases' updates to the PSL.
 
Status: Started (was: Assigned)

Comment 2 by gov...@chromium.org, Apr 25 2018

M67 Stable promotion is coming soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.


*** Bulk Edit ***
M67 Stable promotion is coming soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. 

If fix is already merged to M67 and nothing else is pending, pls mark the bug as fixed. Thank you.
*** Bulk Edit ***
M67 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. 

If fix is already merged to M67 and nothing else is pending, pls mark the bug as fixed. Thank you.
The NextAction date has arrived: 2018-05-08
Project Member

Comment 6 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bb878101be294b3af7dd50509d7fa6ac7a3a9f9

commit 6bb878101be294b3af7dd50509d7fa6ac7a3a9f9
Author: Martijn Croonen <martijnc@chromium.org>
Date: Wed May 09 07:54:57 2018

Refresh Public Suffix List to the latest version.

This updates from revision
0f3b07d9aab6d6c9fe74990af98316468d40f488 (2018-01-25)

to revision
649d6339ff2748e94d076b44e2aecc047795a607(2018-05-08)

Bug:  834407 
Change-Id: I62d38242a534ff2d941d0320c5cd454b9ff8f955
Reviewed-on: https://chromium-review.googlesource.com/1023411
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Martijn Croonen <martijnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557119}
[modify] https://crrev.com/6bb878101be294b3af7dd50509d7fa6ac7a3a9f9/net/base/registry_controlled_domains/effective_tld_names.dat
[modify] https://crrev.com/6bb878101be294b3af7dd50509d7fa6ac7a3a9f9/net/base/registry_controlled_domains/effective_tld_names.gperf

Labels: Merge-Request-67
Requesting a merge to M67.

This is a data-only change, issue 610495 has more background info on the PSL updates and a history of previous PSL merges.
Project Member

Comment 8 by sheriffbot@chromium.org, May 9 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: Less than 16 days to go before AppStore submit on M67
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Thank you  martijnc@.

We still have 2 more beta release left for M67. Is it ok to approve the merge now?
Yup, it's ready to go and no further changes are expected before release (I dealt with all valid pending PSL changes before Martin sent this)
Labels: -Merge-Review-67 Merge-Approved-67
Approving merge to M67 branch 3396 based on comment #7 and #10. Please merge ASAP. Thank you.
Also pls mark bug as fixed after M67 merge if nothing else is pending. Thank you.
Project Member

Comment 13 by bugdroid1@chromium.org, May 9 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0318f5b8b283fb7f910f7d75e06143c21f6ac644

commit 0318f5b8b283fb7f910f7d75e06143c21f6ac644
Author: Martijn Croonen <martijnc@chromium.org>
Date: Wed May 09 21:04:22 2018

Refresh Public Suffix List to the latest version.

This updates from revision
0f3b07d9aab6d6c9fe74990af98316468d40f488 (2018-01-25)

to revision
649d6339ff2748e94d076b44e2aecc047795a607(2018-05-08)

Bug:  834407 
Change-Id: I62d38242a534ff2d941d0320c5cd454b9ff8f955
Reviewed-on: https://chromium-review.googlesource.com/1023411
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Martijn Croonen <martijnc@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#557119}(cherry picked from commit 6bb878101be294b3af7dd50509d7fa6ac7a3a9f9)
Reviewed-on: https://chromium-review.googlesource.com/1052688
Reviewed-by: Martijn Croonen <martijnc@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#538}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/0318f5b8b283fb7f910f7d75e06143c21f6ac644/net/base/registry_controlled_domains/effective_tld_names.dat
[modify] https://crrev.com/0318f5b8b283fb7f910f7d75e06143c21f6ac644/net/base/registry_controlled_domains/effective_tld_names.gperf

Status: Fixed (was: Started)
Blocking: -610495

Sign in to add a comment