iOS supports all formless forms w/o feature flag |
||||||||
Issue description
When Chrome encounters an collection of input elements that are not inside a <form> element, it considers all of them to be part of a form if:
- the page is in English or the language unspecified.
- the page title or URL contains keywords related to billing,
shipping, payment or checkout.
Otherwise, only input elements with an explicit autocomplete attribute are considered to to be part of a form.
A CL (crrev.com/c/735723) landed in M64 errantly removed the check for autofill attributes in iOS, essentially considering all input elements to be part of a form if the other two conditions are not met.
iOS should only behave so if the AutofillRestrictUnownedFieldsToFormlessCheckout flag is disabled.
,
Apr 18 2018
,
Apr 18 2018
Should this block 67?
,
Apr 18 2018
It can. It's an easy fix.
,
Apr 20 2018
,
Apr 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3ddfcbeb59064bb5f3b23d7e67f706bffec0549 commit d3ddfcbeb59064bb5f3b23d7e67f706bffec0549 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Fri Apr 20 19:51:08 2018 [AF] Adds flags for restricting formless form extraction to about_flags Bug: 834404 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I95e93dfae14271e2cd08a42685b8e3f3ad9ff169 Reviewed-on: https://chromium-review.googlesource.com/1022076 Reviewed-by: Roger McFarlane <rogerm@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#552437} [modify] https://crrev.com/d3ddfcbeb59064bb5f3b23d7e67f706bffec0549/chrome/browser/about_flags.cc [modify] https://crrev.com/d3ddfcbeb59064bb5f3b23d7e67f706bffec0549/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/d3ddfcbeb59064bb5f3b23d7e67f706bffec0549/chrome/browser/flag_descriptions.h [modify] https://crrev.com/d3ddfcbeb59064bb5f3b23d7e67f706bffec0549/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/d3ddfcbeb59064bb5f3b23d7e67f706bffec0549/ios/chrome/browser/ios_chrome_flag_descriptions.cc [modify] https://crrev.com/d3ddfcbeb59064bb5f3b23d7e67f706bffec0549/ios/chrome/browser/ios_chrome_flag_descriptions.h [modify] https://crrev.com/d3ddfcbeb59064bb5f3b23d7e67f706bffec0549/tools/metrics/histograms/enums.xml
,
Apr 24 2018
Issue verified Version: Chrome Canary 68.0.3405.0 Device: iPhone 6 iOS: 11.2.6 autofill-restrict-formless-form-extraction flag added to about_flags https://drive.google.com/open?id=1Xa2Vdv4ZFS47YAfyGHiOztWMA3SZQSc9
,
Apr 24 2018
Thanks for verification!
,
Apr 25 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 25 2018
Merged onto 3396 with crrev.com/c/1028492
,
Apr 30 2018
,
Apr 30 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 30 2018
Since this was automatically approved and manually merged, removing merge-approved-67 per comment #12.
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b88963d220694223619130007db1bcc18aa911ea commit b88963d220694223619130007db1bcc18aa911ea Author: Moe Ahmadi <mahmadi@chromium.org> Date: Wed May 02 15:39:12 2018 [AF] Adds flags for restricting formless form extraction to about_flags Bug: 834404 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I95e93dfae14271e2cd08a42685b8e3f3ad9ff169 Reviewed-on: https://chromium-review.googlesource.com/1022076 Reviewed-by: Roger McFarlane <rogerm@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#552437}(cherry picked from commit d3ddfcbeb59064bb5f3b23d7e67f706bffec0549) Reviewed-on: https://chromium-review.googlesource.com/1040005 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#442} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/b88963d220694223619130007db1bcc18aa911ea/chrome/browser/about_flags.cc [modify] https://crrev.com/b88963d220694223619130007db1bcc18aa911ea/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/b88963d220694223619130007db1bcc18aa911ea/chrome/browser/flag_descriptions.h [modify] https://crrev.com/b88963d220694223619130007db1bcc18aa911ea/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/b88963d220694223619130007db1bcc18aa911ea/ios/chrome/browser/ios_chrome_flag_descriptions.cc [modify] https://crrev.com/b88963d220694223619130007db1bcc18aa911ea/ios/chrome/browser/ios_chrome_flag_descriptions.h [modify] https://crrev.com/b88963d220694223619130007db1bcc18aa911ea/tools/metrics/histograms/enums.xml
,
May 9 2018
Verified the issue on 67.0.3396.38 beta tested on iPhone. autofill-restrict-formless-form-extraction flag added in chrome://flags |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by mahmadi@chromium.org
, Apr 18 2018