Do not send workspace changed event when showing hidden shelf in overview. |
||
Issue descriptionSometimes shelf is hidden because app is fullscreened. The shelf comes back into view when entering overview but we should not notify apps that the workspace has changed, because it has not. We should still make sure overview uses the workspace bounds even if an app has been fullscreened.
,
Jul 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa0e1405bc2bbed8ba976749a8369f6c8050b72d commit fa0e1405bc2bbed8ba976749a8369f6c8050b72d Author: Mitsuru Oshima <oshima@chromium.org> Date: Wed Jul 18 15:57:37 2018 Do not change the workspace when entering/leaving overview * This also fixes the IsSelecting so that it returns false during shutdown. BUG= 834400 TEST=Covered by unit test Change-Id: Iac0cb8a3bdf03609727c31c51000c52ececfc66a Reviewed-on: https://chromium-review.googlesource.com/1140749 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#576078} [modify] https://crrev.com/fa0e1405bc2bbed8ba976749a8369f6c8050b72d/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/fa0e1405bc2bbed8ba976749a8369f6c8050b72d/ash/wm/overview/window_selector_controller.cc [modify] https://crrev.com/fa0e1405bc2bbed8ba976749a8369f6c8050b72d/ash/wm/overview/window_selector_unittest.cc
,
Jul 20
|
||
►
Sign in to add a comment |
||
Comment 1 by osh...@chromium.org
, Jul 17Owner: osh...@chromium.org
Status: Started (was: Assigned)