Modern Media Controls: Play button doesn't show pause icon while playing |
||||
Issue descriptionTo repro: Go to https://mounirlamouri.github.io/sandbox/media/dynamic-controls.html Change width to 95 to make the video small enough to show the non-overlay play button Click on the non-overlay play button Expected: Video starts playing and the button shows a pause icon Actual: Video starts playing but the button continues to show the play icon
,
Apr 18 2018
,
Apr 19 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/305b9c643c7026f28ce0ab140decfc6b6c34c25a commit 305b9c643c7026f28ce0ab140decfc6b6c34c25a Author: Tommy Steimel <steimel@chromium.org> Date: Thu Apr 19 21:50:28 2018 Show pause icon on non-overlay play button when playing This CL adds a CSS rule to show a white pause icon on the non-overlay play button when a video is playing. Bug: 834396 Change-Id: I94694d2a3cecdb62d4f4a53b819e2f744ce61659 Reviewed-on: https://chromium-review.googlesource.com/1017345 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#551834}(cherry picked from commit fdd872918d46047f1471404736865a2390e62b34) Reviewed-on: https://chromium-review.googlesource.com/1020380 Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#150} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [add] https://crrev.com/305b9c643c7026f28ce0ab140decfc6b6c34c25a/third_party/WebKit/LayoutTests/media/controls/modern/show-pause-icon-on-non-overlay-play-button.html [modify] https://crrev.com/305b9c643c7026f28ce0ab140decfc6b6c34c25a/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Apr 18 2018