New issue
Advanced search Search tips

Issue 834388 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 820421
issue 837642



Sign in to add a comment

assign dedicated slave to win bot on angle waterfall

Project Member Reported by thakis@chromium.org, Apr 18 2018

Issue description

See  issue 820421  comment 81 and 82.
 

Comment 1 by thakis@chromium.org, Apr 18 2018

Blockedon: 820421
re #82: you set up the scheduler entry in https://chromium.googlesource.com/angle/angle/+log/infra/config/luci-scheduler.cfg

re why it shares the win builder's slave: the dimensions we're setting for angle in cr-buildbucket.cfg only include the pool and the os, not the builder name; doing so apparently requires adding auto_builder_dimension: YES (e.g. https://chromium.googlesource.com/chromium/src/+/master/infra/config/global/cr-buildbucket.cfg#399)

Comment 3 by thakis@chromium.org, Apr 18 2018

Are the `dimensions: "builder:win-msvc"` lines in https://chrome-internal.googlesource.com/infradata/config/+/master/configs/chromium-swarm/bots.cfg#172 unused atm then? I.e. can I remove them for the try bot_groups?
Would I be right in thinking that setting the dimension for the builder would mean faster re-compiles, because the same builder wouldn't be trying to build both MSVC and Clang?

Comment 5 by thakis@chromium.org, Apr 27 2018

Right now, there's just one win slave for the main waterfall. If you got a second slave assigned to the main waterfall and set the dimensions differently, then yes, win/msvc and win/clang would each have their dedicated slave and they could build concurrently. But if you have just one slave and set the dimension, then the win/msvc bot will cycle twice as fast but no slave would be around for doing the win/clang builds.
Cc: thakis@chromium.org jbudorick@chromium.org
Owner: jmad...@chromium.org
OK. I'll see if I can handle this as part of  issue 833999 
Blockedon: 837642
Project Member

Comment 8 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/958de8e9747692937531b48033eedcadcaa807a5

commit 958de8e9747692937531b48033eedcadcaa807a5
Author: Jamie Madill <jmadill@chromium.org>
Date: Fri May 04 15:04:19 2018

Project Member

Comment 9 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/3a1ee730381eca88ea247ac37b455b65ca491cf4

commit 3a1ee730381eca88ea247ac37b455b65ca491cf4
Author: Jamie Madill <jmadill@chromium.org>
Date: Fri May 04 17:39:51 2018

Status: Fixed (was: Assigned)

Sign in to add a comment