Issue metadata
Sign in to add a comment
|
font-stretch should allow 0% as a valid value. |
||||||||||||||||||||||||
Issue description
Chrome Version: (copy from chrome://version)
OS: (e.g. Win10, MacOS 10.12, etc...)
What steps will reproduce the problem?
(1) Run in the console: CSS.supports('font-stretch', '0%')
What is the expected result?
True
What happens instead?
False
See https://github.com/w3c/csswg-drafts/issues/2591
,
Oct 26
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e08cc689fdbe7717ed3cbe32dc19a8f5bd52c20b commit e08cc689fdbe7717ed3cbe32dc19a8f5bd52c20b Author: Yunlian Jiang <yunlian@google.com> Date: Fri Oct 26 19:14:53 2018 virtual/target-chromium-os-test: temporarily disable toolchain-tests. Current platform_ToolchainTest only works for glibc 2.23. CL:1139076 only works for glibc 2.27. And we could not upgrade glibc and this test in the same time. This is because the glibc is built by the sdk bot, but the test is for the target. If we upgrade these two package at the same time, in the commit queue buildbot it will cause unittest fail. To workaround that, we disable this test temporarily and check in the change for glibc 2.27. After glibc 2.27 roll finishes, we enable this test again. BUG= chromium:834384 TEST=toolchain-tests does not run in cros_run_unittest. Change-Id: Icc6e57353746571f7d00ec2696242db84d7b36ff Reviewed-on: https://chromium-review.googlesource.com/1300194 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> [rename] https://crrev.com/e08cc689fdbe7717ed3cbe32dc19a8f5bd52c20b/virtual/target-chromium-os-test/target-chromium-os-test-1-r74.ebuild [modify] https://crrev.com/e08cc689fdbe7717ed3cbe32dc19a8f5bd52c20b/virtual/target-chromium-os-test/target-chromium-os-test-1.ebuild
,
Oct 27
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ca096aaa6768909963bdc1d6cd84ed1965ecc07a commit ca096aaa6768909963bdc1d6cd84ed1965ecc07a Author: Yunlian Jiang <yunlian@google.com> Date: Sat Oct 27 16:32:21 2018 toolchain-tests: temporarily disable toolchain-tests. Current platform_ToolchainTest only works for glibc 2.23. CL:1139076 only works for glibc 2.27. And we could not upgrade glibc and this test in the same time. This is because the glibc is built by the sdk bot, but the test is for the target. If we upgrade these two package at the same time, in the commit queue buildbot it will cause unittest fail. To workaround that, we disable this test temporarily and check in the change for glibc 2.27. After glibc 2.27 roll finishes, we enable this test again. BUG= chromium:834384 TEST=toolchain-tests does not run in cros_run_unittest. Change-Id: If03aca3bf1907b9170c3c302c9298f989dd1b2ba Reviewed-on: https://chromium-review.googlesource.com/c/1303276 Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Yunlian Jiang <yunlian@chromium.org> [modify] https://crrev.com/ca096aaa6768909963bdc1d6cd84ed1965ecc07a/chromeos-base/toolchain-tests/toolchain-tests-9999.ebuild
,
Oct 29
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8d9938a422b859a65d9ecf78aad8f3f34eb5d126 commit 8d9938a422b859a65d9ecf78aad8f3f34eb5d126 Author: Yunlian Jiang <yunlian@google.com> Date: Mon Oct 29 18:21:40 2018 virtual/target-chromium-os-test: re-enable toolchain-tests. We have disabled the toolchain-tests in toolchain-tests.ebuild, there is no need to remove it from dependency list. BUG= chromium:834384 TEST=toolchain-tests does not run in cros_run_unittest. Change-Id: Iaa3eee9d0fa7719b34c04414b2e3cb288ee5fd5b Reviewed-on: https://chromium-review.googlesource.com/1303289 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Yunlian Jiang <yunlian@chromium.org> [modify] https://crrev.com/8d9938a422b859a65d9ecf78aad8f3f34eb5d126/virtual/target-chromium-os-test/target-chromium-os-test-1.ebuild [rename] https://crrev.com/8d9938a422b859a65d9ecf78aad8f3f34eb5d126/virtual/target-chromium-os-test/target-chromium-os-test-1-r75.ebuild |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by cnardi@chromium.org
, Apr 18 2018Status: Duplicate (was: Available)