LXC tests have a bad import. |
||
Issue description
Error looks like:
class ContainerFactoryTests(lxc.utils.LXCTests):
AttributeError: 'module' object has no attribute 'utils'
lxc.py and lxc the directory are not the same.
This is causing test failures (or just flake?) in ToT.
,
Apr 18 2018
It caused a unit test failure in that build. There may have be two problems.
,
Apr 18 2018
Correction: It caused a compilation failure while attempting to run unit tests. Which, yes, caused the failed build. Which leaves the question of why this wasn't caught before. How intelligent is the CQ about running new tests?
,
Apr 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/35b0e76322e80c739e516ac917e44932944ed921 commit 35b0e76322e80c739e516ac917e44932944ed921 Author: Jacob Kopczynski <jkop@google.com> Date: Wed Apr 18 19:49:39 2018 autotest: lxc: fix shadowed import BUG= chromium:834378 TEST=unit tests went from red to green Change-Id: I0a062694fbede618e4387b36c928637b71c92195 Reviewed-on: https://chromium-review.googlesource.com/1017314 Commit-Queue: Jacob Kopczynski <jkop@chromium.org> Tested-by: Jacob Kopczynski <jkop@chromium.org> Trybot-Ready: Jacob Kopczynski <jkop@chromium.org> Reviewed-by: Xixuan Wu <xixuan@chromium.org> [modify] https://crrev.com/35b0e76322e80c739e516ac917e44932944ed921/site_utils/lxc/container_factory_unittest.py [modify] https://crrev.com/35b0e76322e80c739e516ac917e44932944ed921/site_utils/lxc/container_bucket_unittest.py [modify] https://crrev.com/35b0e76322e80c739e516ac917e44932944ed921/site_utils/lxc/shared_host_dir_unittest.py
,
Apr 18 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by xixuan@chromium.org
, Apr 18 2018