New issue
Advanced search Search tips

Issue 834357 link

Starred by 2 users
Status: Fixed
Owner:
ellyjo...@chromium.org
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[MacViews-Browser] Bookmark Star Icon in the Omnibox is hard to see in Incognito Mode

Project Member Reported by meh...@chromium.org, Apr 18 2018 
Chrome Version: Chromium Snapshot #551710
OS: macOS 10.12.6

What steps will reproduce the problem?
(1) Enable MacViews-Browser
(2) Open an Incognito Window
(3) Take a look at the Bookmarks Star Icon in the Omnibox

After the CL https://chromium-review.googlesource.com/1014738 has been landed and the Dropdown and the Omnibox are dark again (thanks!) the Bookmarks Star Icon is hard to see. Maybe it could have the same color like the magnifying glass on the left side of the Omnibox.

A screenshot is attached.

Thanks
Mehmet
Bildschirmfoto 2018-04-18 um 19.03.49.png
76.0 KB View Download

Comment 1 by dschuyler@chromium.org, Apr 19 2018

Cc: -ellyjo...@chromium.org
Owner: ellyjo...@chromium.org
Status: Assigned (was: Untriaged)
ellyjones@ this sounds like something you'd be familiar with.

Comment 2 by ellyjo...@chromium.org, Apr 19 2018

Labels: M-68 MacViews-Browser Sprint-1 Target-68
Yup, this is a me sort of bug.

Comment 3 by gov...@chromium.org, Apr 25 2018 

Pls mark the bug as fixed if CL is landed in trunk and nothing else is pending. Thank you.

Comment 4 by ellyjo...@chromium.org, Apr 26 2018

Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/chromium/src/+/1030040
before.png
23.5 KB View Download
after.png
23.2 KB View Download

Comment 5 by meh...@chromium.org, Apr 26 2018 

Looks great, thanks :-)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94c32dea3719244da1079b52ba1c8d6811f8cb3c

commit 94c32dea3719244da1079b52ba1c8d6811f8cb3c
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Thu Apr 26 17:47:37 2018

macviews: use dark theme in incognito windows

This change fixes two separate bugs:

1) The security text is drawn dark instead of light
2) The star icon and other decorations are drawn dark instead of light

Bug:  834357 
Change-Id: Ie58c26bc60d0d0b371562e2f92727e0896f5766d
Reviewed-on: https://chromium-review.googlesource.com/1030040
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554072}
[modify] https://crrev.com/94c32dea3719244da1079b52ba1c8d6811f8cb3c/chrome/browser/ui/views/frame/browser_frame.cc

Comment 7 by gov...@chromium.org, Apr 27 2018 

Can this be marked as fixed now if nothing else is pending?

Comment 8 by vamshi.kommuri@chromium.org, Apr 27 2018

Labels: TE-Verified-M68 TE-Verified-68.0.3410.0
Verified the fix on Mac 10.13.1 using Chrome version #68.0.3410.0 as per the comment #0.
Attaching screen shot for reference.
Observed that Bookmark icon (...star) is properly colored.
Hence, the fix is working as expected. 
Adding the verified labels.
Note: Able to reproduce the issue on chrome version with out fix.

Thanks...!!
834357 CL Verif.png
1.1 MB View Download

Comment 9 by ellyjo...@chromium.org, Apr 27 2018

Status: Fixed (was: Started)
►

Sign in to add a comment