Issue metadata
Sign in to add a comment
|
Gaps in accessibility implementation for autofill views |
||||||||||||||||||||||||
Issue descriptionThe new autofill views implementation has some issues in the a11y implementation. - Focusability not set correctly (separators are focusable and menu items are not, it should be the reverse) - Accessibility role is not set correctly - Setsize and posinset not set - Accessibility events not fired There may be other issues as well.
,
Apr 19 2018
Hey, just wanted to check in, are you doing an audit, making code changes, or both? Either way I really appreciate it! I wanted to give you a heads-up that some of this code is still changing pretty substantially, so let's make sure to coordinate on any code changes.
,
Apr 19 2018
I sent you a CL with some changes. They aren't that big. I need to get at least part of the fix in so that I can land another change. It's blocking me on https://chromium-review.googlesource.com/c/chromium/src/+/981937 Is it conflicting with an upcoming change of yours? I could rebase it on that. Show me whatchu got....
,
Apr 19 2018
Also, the crucial change for unblocking me (as opposed to actually fixing the accessibility) is the logic for is_separator_ ? FocusBehavior::NEVER : FocusBehavior::ALWAYS;
,
Apr 19 2018
No, the CL you sent shouldn't cause any major conflicts. I lgtm'd your change, it all makes sense to me. I have a number of changes in progress, but these improvements should be relatively easy to integrate into them.
,
Apr 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/862bbe7eae9779123bee26ab840393444cac7151 commit 862bbe7eae9779123bee26ab840393444cac7151 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Sat Apr 21 02:54:59 2018 Accessibility fixes for autofill views Correct the focus behavior setting for menu items, copy previous improvements in autofill semantics, fire accessibility events. Bug: 834346 Change-Id: Ibc7413d50491f0c40a2e0b30a4719c7563bf7dfa Reviewed-on: https://chromium-review.googlesource.com/1016673 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Nektarios Paisios <nektar@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#552561} [modify] https://crrev.com/862bbe7eae9779123bee26ab840393444cac7151/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc [modify] https://crrev.com/862bbe7eae9779123bee26ab840393444cac7151/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.h [modify] https://crrev.com/862bbe7eae9779123bee26ab840393444cac7151/chrome/browser/ui/views/autofill/autofill_popup_view_native_views_unittest.cc [modify] https://crrev.com/862bbe7eae9779123bee26ab840393444cac7151/ui/views/accessibility/native_view_accessibility_base.cc
,
Apr 21 2018
,
Jun 5 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by aleventhal@chromium.org
, Apr 19 2018