New issue
Advanced search Search tips

Issue 834340 link

Starred by 1 user
Status: WontFix
Owner:
jgruber@chromium.org
Closed: May 2018
Cc:
huangs@google.com
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

43.9 KiB regression in resource_sizes (MonochromePublic.apk) at 551586:551586

Project Member Reported by huangs@google.com, Apr 18 2018 
Caused by “[builtins] Re-enable embedded builtins”

Chromium Commit: abc123abc123abc123abc123abc123abc123abcd

Review: https://chromium-review.googlesource.com/#/c/1013570/

Link to size graph: https://chromeperf.appspot.com/report?sid=a097e74b1aa288511afb4cb616efe0f95ba4d347ad61d5e835072f23450938ba&num_points=10&rev=480214

Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase

Based on the graph: 43.9 KiB native code.

It looks like this increase was probably unexpected or might be avoidable.
Please have a look and either:

Close as “Won't Fix” with a short justification, or
Land a revert / fix-up.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Apr 18 2018 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=834340

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=0547188f589d1316fd9adee4b028eab33f188846996483639bfab8c9e5783dfe


Bot(s) for this bug's original alert(s):

Android Builder Perf
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Apr 18 2018

Owner: v8-autoroll@chromium.org
Status: Assigned (was: Untriaged)
Assigning to v8-autoroll@chromium.org because this is the only CL in range:
Update V8 to version 6.8.34.

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/059b1287..bde5be65

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Iae7c5b0f4356f1f808e55c7ea16f912ca0ce88e1
Reviewed-on: https://chromium-review.googlesource.com/1016044
Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551586}

Comment 3 by estevenson@chromium.org, May 9 2018

Owner: jgruber@chromium.org

Comment 4 by jgruber@chromium.org, May 14 2018

Status: WontFix (was: Assigned)
Embedded builtins move code from the snapshot file into libv8.so / the chrome binary in static builds. The produced code is a bit larger, plus we lose the compression of the serialized snapshot format, so a minor regression like this is expected and will be offset by significant improvements at runtime.
►

Sign in to add a comment